825191 - Remove nsContentUtils::EqualsLiteralIgnoreASCIICase

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

This can simply use str.LowerCaseEqualsLiteral().

See <http://mxr.mozilla.org/mozilla-central/ident?i=EqualsLiteralIgnoreASCIICase> for the places where this is used.

Comment 1

[sir.seven.hong]

Hi :) So if I wanna modify it, should I replace all codes like EqualsLiteralIgnoreASCIICase(str) with str.LowerCaseEqualsLiteral() ?

Comment 2

[sir.seven.hong]

Oh and how should I get something like :Seven_Hong on top of my comment box, like you guys have :Somename ? Many thanks! :D

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to sir.seven.hong from comment #1)
> Hi :) So if I wanna modify it, should I replace all codes like
> EqualsLiteralIgnoreASCIICase(str) with str.LowerCaseEqualsLiteral() ?

Correct.

Comment 4

[Gaurav Pruthi]

Hi , can I be assigned this bug ??

Comment 5

[[:badanomaly]]

Attachment: Diff created from the mozilla-central directory for bug 825191

Comment 6

[[:badanomaly]]

Hi !! I have attached a patch. What should be my next step ?

Comment 7

[Edmund Wong (:ewong)]

(In reply to Mohit Gahlot ( :mgahlot ) from comment #6)
> Hi !! I have attached a patch. What should be my next step ?

Wait for the review to be done; but you need to specify the right
person

Comment 8

[[:badanomaly]]

(In reply to Edmund Wong (:ewong) from comment #7)
> (In reply to Mohit Gahlot ( :mgahlot ) from comment #6)
> > Hi !! I have attached a patch. What should be my next step ?
> 
> Wait for the review to be done; but you need to specify the right
> person

Where do I need to specify ? and how am I supposed to know who is the right person ?

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 696960 [details] [diff] [review]
Diff created from the mozilla-central directory for bug 825191

Review of attachment 696960 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for taking this on! You patch looks good. One thing, though: we use

if (foo)

not

if ( foo )

(Note the spaces.) Could you just change that and request review from ':mounir'?

Comment 10

[[:badanomaly]]

Attachment: Patch 2

Comment 11

[[:badanomaly]]

(In reply to :Ms2ger from comment #9)
> Comment on attachment 696960 [details] [diff] [review]
> Diff created from the mozilla-central directory for bug 825191
> 
> Review of attachment 696960 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks for taking this on! You patch looks good. One thing, though: we use
> 
> if (foo)
> 
> not
> 
> if ( foo )
> 
> (Note the spaces.) Could you just change that and request review from
> ':mounir'?

Done. I think.

Comment 12

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Mohit Gahlot ( :mgahlot ) from comment #8)
> (In reply to Edmund Wong (:ewong) from comment #7)
> > (In reply to Mohit Gahlot ( :mgahlot ) from comment #6)
> > > Hi !! I have attached a patch. What should be my next step ?
> > 
> > Wait for the review to be done; but you need to specify the right
> > person
> 
> Where do I need to specify ? and how am I supposed to know who is the right
> person ?

Look for a module owner or peer for the code you changed on <https://wiki.mozilla.org/Modules/All> (or just ask someone).

Comment 13

[Mounir Lamouri (:mounir)]

Comment on attachment 696961 [details] [diff] [review]
Patch 2

Review of attachment 696961 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Thank you for this patch :)

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2b383c3ba330

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2b383c3ba330