825224 - Make DEBUG=1 profiles pick up l10n files correctly

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Axel Hecht [:Pike]]

There were a bunch of assumptions in our hack of httpd.js to support hg locale repos inside gaia/locales that are no longer true.

I've patched that locally to work reliably again, and didn't find any issues in ftu, contacts, homescreen and shared/date.

Requesting blocking-basecamp to support both localizers as well as developers to quickly test against the localization content as it is in hg.

Comment 1

[Axel Hecht [:Pike]]

Attachment: fix up httpd.js to just drop /locales/, find and replace the locale code. Also resolves ..

There were a bunch of complicated assumptions, I boiled them down to:

resolve '..' first, so you end up with top-level paths to either /shared/.. or /apps/.. .
remove 'locales' from the path parts
find the locale code in the file name, and remove it
try to load localeCode + moddedPath.join('/')

Comment 2

[Doug Turner (:dougt)]

Not a blocker.  Please request uplift on the patches (assuming they are safe, etc)

Comment 3

[Axel Hecht [:Pike]]

FYI, this blends with 
build/multilocale.py -i --target=shared --target=apps/browser de
to modify the ini files to hook up a particular locale.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 696314 [details]
fix up httpd.js to just drop /locales/, find and replace the locale code. Also resolves ..

Trying Vivien for the PR review here.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 696314 [details]
fix up httpd.js to just drop /locales/, find and replace the locale code. Also resolves ..

To be honest since this code has been written by stas I will be comfortable is stas review it.

Comment 6

[Staś Małolepszy :stas]

Pike, I know you've rebased your patch recently, can you push -f to your branch so that I can test it?

Comment 7

[Axel Hecht [:Pike]]

I think I pushed it, https://github.com/mozilla-b2g/gaia/pull/7229/commits talks about March 20.

Comment 8

[Staś Małolepszy :stas]

Comment on attachment 696314 [details]
fix up httpd.js to just drop /locales/, find and replace the locale code. Also resolves ..

Ah, you're right.  I tested the patch and indeed it picks up the l10n files from gaia-l10n repos correctly also for communications/*.

(I still had troubles with caching and had to first access the file by typing it's URL in the address bar, but this has nothing to do with this patch.)

Comment 9

[Francesco Lodolo [:flod]]

Stumbled upon this bug and bug 824978 today, not sure what to make of them (the second one looks like a WONTFIX at this point).

Comment 10

[Staś Małolepszy :stas]

Needinfo'ing myself to look at this on Wednesday.

Comment 11

[Axel Hecht [:Pike]]

Unassigning myself, I'm not actively working on this, and I'm not sure if I will anytime soon.

Comment 12

[Staś Małolepszy :stas]

Clearly I didn't get to work on this either.  I wonder, should we just kill this feature and clean up the httpd.js and the Makefile?

Comment 13

[Axel Hecht [:Pike]]

Grumble, https://dxr.mozilla.org/mozilla-central/search?q=path%3A%2Fhttpd.js&case=true.

Regarding the actual question, I haven't kept track on fx os l10n, and I don't know if anybody actually uses this feature. Ask in .l10n?

Comment 14

[BMO Automation]

Firefox OS is not being worked on