825228 - remove nsAccessNode::IsElement()

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: patch

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 696317 [details] [diff] [review]
patch

Review of attachment 696317 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/generic/DocAccessible.cpp
@@ +1569,5 @@
>    nsEventShell::FireEvent(stateEvent);
>  }
>  
>  void
> +DocAccessible::AddDependentIDsFor(dom::Element* aRelProvider,

pls rename it to aRelProviderElm

@@ +1630,5 @@
>    }
>  }
>  
>  void
> +DocAccessible::RemoveDependentIDsFor(dom::Element* aRelProvider,

same here

@@ +1949,5 @@
>  DocAccessible::UncacheChildrenInSubtree(Accessible* aRoot)
>  {
>    aRoot->mStateFlags |= eIsNotInDocument;
>  
> +  nsIContent* content = aRoot->GetContent();

I'd name it as rootContent

::: accessible/src/generic/DocAccessible.h
@@ +361,5 @@
>     *
>     * @param aRelProvider [in] accessible that element has relation attribute
>     * @param aRelAttr     [in, optional] relation attribute
>     */
> +  void AddDependentIDsFor(dom::Element* aRelProvider,

add 'Elm'

@@ +372,5 @@
>     *
>     * @param aRelProvider [in] accessible that element has relation attribute
>     * @param aRelAttr     [in, optional] relation attribute
>     */
> +  void RemoveDependentIDsFor(dom::Element* aRelProvider,

same

Comment 3

[Trevor Saunders (:tbsaunde)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3e93160349b0

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3e93160349b0