We should not save the ETag if the package is incorrect

RESOLVED FIXED in Firefox 19

Status

()

Core
DOM: Apps
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: julienw, Assigned: julienw)

Tracking

Trunk
mozilla20
ARM
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking-basecamp:+, firefox19 fixed, firefox20 fixed, b2g18 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Bug 820630 introduced the support of ETag.

However, we save the ETag value even if the package is bad. Therefore if there is an ETag, the user can retry the download, and the download will be somewhat applied in an inconsistent way.

STR:
* go to http://owapps.cloudfoundry.com
* install the packaged app
=> installation stopped, which is expected because the manifest is not right
* go to the homescreen and restart the download by pressing the icon
=> installation sort of finishes. Except the icon is not right, and the app can't be launched

Nominating but I don't think it should block v1 because the error is correctly written in the log at the first install.

However the fix should be easy (storing the |app.packageEtag| just after |app.appStatus|)
Julien: Can you take this?
Assignee: nobody → felash
blocking-basecamp: ? → +
(Assignee)

Comment 2

4 years ago
Yep :) But not before Monday now.
(Assignee)

Comment 3

4 years ago
Created attachment 696495 [details] [diff] [review]
patch v1

should be applied after the patch for bug 824695
Attachment #696495 - Flags: review?(jonas)

Updated

4 years ago
Depends on: 824695
Attachment #696495 - Flags: review?(jonas) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/90cd09c695ed
(Assignee)

Comment 5

4 years ago
To whoever will check in to other trees, this need to go in aurora and b2g18 as well.
https://hg.mozilla.org/mozilla-central/rev/90cd09c695ed
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20

Updated

4 years ago
Keywords: verifyme
QA Contact: jsmith
https://hg.mozilla.org/releases/mozilla-aurora/rev/4dd1bf0fef35
https://hg.mozilla.org/releases/mozilla-b2g18/rev/0c64ef06796c
status-b2g18: --- → fixed
status-firefox19: --- → fixed
status-firefox20: --- → fixed
(In reply to Julien Wajsberg [:julienw] from comment #5)
> To whoever will check in to other trees, this need to go in aurora and b2g18
> as well.

(FWIW, for bugs marked blocking-basecamp+, I have bug queries to tell me this :)...)

Updated

4 years ago
Keywords: verifyme
Whiteboard: [qa-]

Updated

4 years ago
Blocks: 802574
No longer blocks: 777048
You need to log in before you can comment on or make changes to this bug.