Closed
Bug 825275
Opened 12 years ago
Closed 12 years ago
DNS cache enumerator crashes
Categories
(Core :: Networking: DNS, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: jdm, Assigned: jaas)
References
()
Details
Attachments
(1 file)
|
771 bytes,
patch
|
sworkman
:
review+
|
Details | Diff | Splinter Review |
>1075 while (addr) {
>1076 char buf[kIPv6CStrBufSize];
>1077 if (NetAddrToString(addr, buf, sizeof(buf))) {
>1078 info.hostaddr.AppendElement(buf);
>1079 }
>1080 addrElement = addrElement->getNext();
>1081 if (addrElement) {
>1082 addr = &addrElement->mAddress;
>1083 }
>1084 }
addr is not updated if addrElement is null, so we loop again and deref the null addrElement. Christian hit this with https://crash-stats.mozilla.com/report/index/e5bbb75d-a6af-4af2-b942-9ee3d2121228.
|
||
Updated•12 years ago
|
This is probably my fault.
Assignee: valentin.gosu → joshmoz
Attachment #696615 -
Flags: review?(sworkman)
|
||
Updated•12 years ago
|
Attachment #696615 -
Flags: review?(sworkman) → review+
|
||
Comment 3•12 years ago
|
||
Comment on attachment 696615 [details] [diff] [review]
fix v1.0
Review of attachment 696615 [details] [diff] [review]:
-----------------------------------------------------------------
steve's review is fine by me.
pushed to mozilla-inbound
http://hg.mozilla.org/integration/mozilla-inbound/rev/37f6cc6d5bf3
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•