825286 - Use ManifestHelper to get localized manifest data

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[:Margaret Leibovic]

Bug 824418 added a new ManifestHelper object, which can be used to get localized manifest data.

In everything.me, there's a getAppName() function that could use this, but it looks like there are other places where we directly call manifest.name, and we should make sure we're using the correctly localized properties wherever they're used.

Comment 1

[Ran Ben Aharon [:ranbena] EverythingMe]

Philip fixed this a while ago in https://bugzilla.mozilla.org/show_bug.cgi?id=807529
You can see the changed code here https://github.com/mozilla-b2g/gaia/commit/56b368723178521be7f6d417e7944fa7b909d1a8#L3R69

Comment 2

[:Margaret Leibovic]

(In reply to Ran Ben Aharon (Everything.me) from comment #1)
> Philip fixed this a while ago in
> https://bugzilla.mozilla.org/show_bug.cgi?id=807529
> You can see the changed code here
> https://github.com/mozilla-b2g/gaia/commit/
> 56b368723178521be7f6d417e7944fa7b909d1a8#L3R69

Yeah, I saw that. This bug is about the fact that the code could be made simpler if ManifestHelper is used. Feel free to resolve as WONTFIX if you don't want to do this.

Comment 3

[Evyatar 'Tron' Amitay (everything.me)]

Cristian, is this relevant to us?

Comment 4

[Cristian Rodriguez (:crdlc)]

I don't know if evme is reading names from manifest. If it happens you should the ManifestHelper object

Comment 5

[Ran Ben Aharon [:ranbena] EverythingMe]

Cristian, the only place where manifest.name is called is in etmmanager.js
https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/everything.me/js/etmmanager.js#L358

Comment 6

[Cristian Rodriguez (:crdlc)]

It makes sense because bookmarks have not locales so this bug is invalid right now