825325 - ImageContainer::NotifyPaintedImage is not called on android.

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Paul Adenot (:padenot)]

This makes the mozPaintedFrames property of the media elements report wrong values.

Maybe we need to call it from http://mxr.mozilla.org/mozilla-central/source/gfx/layers/opengl/ImageLayerOGL.cpp#963

Testcase: http://paul.cx/public/mozPaintedFrame.html

Comment 1

[Paul Adenot (:padenot)]

Attachment: Patch.

Comment 2

[Paul Adenot (:padenot)]

Attachment: Patch

This is better.

Comment 3

[Paul Adenot (:padenot)]

Attachment: ImageContainer::NotifyPaintedImage is not called on android. r=

Comment 4

[Paul Adenot (:padenot)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/70bb7f775178

Comment 5

[Ed Morley [:emorley]]

Push backed out for Windows pgo-only mochitest-1 timeouts in media tests, since the backout of just 1abf4c88f8f1 didn't work (see bug 793274 comment 12 for example logs):
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2912b7e727a

Comment 6

[Paul Adenot (:padenot)]

After bisecting the queue on try, this patch has been proved to cause no problem [0], note the patch at the top of the queue that requests a PGO build. The problem remains in the other part of the queue [1].

This has been pushed as https://hg.mozilla.org/integration/mozilla-inbound/rev/109bbd733301

[0]: https://tbpl.mozilla.org/?tree=Try&rev=516ddf4c963c
[1]: https://tbpl.mozilla.org/?tree=Try&rev=418c581b8023

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/109bbd733301