Closed Bug 825505 Opened 8 years ago Closed 8 years ago

crash when calling 'Edit' context menu for site/page/thumbnail on about:home and returning to it with the 'Back' button: [@ java.lang.NullPointerException: at org.mozilla.gecko.AboutHomeContent$17.onActivityResult(AboutHomeContent.java) ]

Categories

(Firefox for Android :: Awesomescreen, defect)

ARM
Android
defect
Not set
critical

Tracking

()

RESOLVED FIXED
Firefox 20
Tracking Status
firefox20 + fixed

People

(Reporter: aryx, Assigned: wesj)

Details

(Keywords: crash, topcrash, Whiteboard: [native-crash])

Crash Data

Attachments

(1 file)

Firefox for Android trunk 20121230, Android 4.1.2 (stock), Google Nexus S

This bug was filed from the Socorro interface and is 
report bp-1a6be7b5-7920-49d7-80a2-d486d2121230 .
============================================================= 

There is a crash when calling 'the Edit' context menu for a page on about:home and returning to it (from the awesome screen) with the 'Back' button: [@ java.lang.NullPointerException: at org.mozilla.gecko.AboutHomeContent$17.onActivityResult(AboutHomeContent.java) ] 

This feature landed two days ago: http://hg.mozilla.org/mozilla-central/rev/a9c2f983a4ea
Assignee: nobody → wjohnston
Severity: normal → critical
Whiteboard: [native-crash]
Let's also remove the Log.i here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/AboutHomeContent.java#991

We don't want to be dumping URLs into logcat if we can help it.
This is the unfixed topcrash on 20 for Android at this time.
Keywords: topcrash
Attached patch PatchSplinter Review
I was just going to test the resultCode here, but AwesomeBarResultHandler doesn't check it and instead depends on data != null:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/AwesomebarResultHandler.java#15

which scared me into doing both for now.
Attachment #697106 - Flags: review?(mark.finkle)
Attachment #697106 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/0515eda1f932
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.