825505 - crash when calling 'Edit' context menu for site/page/thumbnail on about:home and returning to it with the 'Back' button: [@ java.lang.NullPointerException: at org.mozilla.gecko.AboutHomeContent$17.onActivityResult(AboutHomeContent.java) ]

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox for Android trunk 20121230, Android 4.1.2 (stock), Google Nexus S

This bug was filed from the Socorro interface and is 
report bp-1a6be7b5-7920-49d7-80a2-d486d2121230 .
============================================================= 

There is a crash when calling 'the Edit' context menu for a page on about:home and returning to it (from the awesome screen) with the 'Back' button: [@ java.lang.NullPointerException: at org.mozilla.gecko.AboutHomeContent$17.onActivityResult(AboutHomeContent.java) ] 

This feature landed two days ago: http://hg.mozilla.org/mozilla-central/rev/a9c2f983a4ea

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Let's also remove the Log.i here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/AboutHomeContent.java#991

We don't want to be dumping URLs into logcat if we can help it.

Comment 2

[Robert Kaiser]

This is the unfixed topcrash on 20 for Android at this time.

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch

I was just going to test the resultCode here, but AwesomeBarResultHandler doesn't check it and instead depends on data != null:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/AwesomebarResultHandler.java#15

which scared me into doing both for now.

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0515eda1f932

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0515eda1f932