825611 - Always provide as much audio data from PeerConnection as MediaStreamGraph asks for

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Maire Reavy [:mreavy]]

The GIPS code always provides audio data in 10ms fixed buffers.  MediaStreamGraph may ask for audio in any buffer size.  Even if MediaStreamGraph requests just slightly more than 10ms, provide the full second 10ms buffer and let the rest of the code handle it.  The jitter buffer will grow, but that's ok.  We can worry about optimizing the sizes requested by MediaStreamGraph in a separate bug.

Implementing this fix should eliminate some (hopefully all) of the audio artifacts we're hearing from the output side of the current PeerConnection code.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

See bug 822956 comment 23 and following

Comment 2

[Eric Rescorla (:ekr)]

Attachment: Have MediaPipeline deliver as much media as requested

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 698200 [details] [diff] [review]
Have MediaPipeline deliver as much media as requested

Review of attachment 698200 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp
@@ +828,5 @@
>      MOZ_MTLOG(PR_LOG_ERROR, "NotifyPull() called from a non-SourceMediaStream");
>      return;
>    }
>  
> +  while (MillisecondsToMediaTime(played_) < desired_time) {

Just add a comment that that it's done this way to avoid roundoff errors from accumulating.

Comment 4

[Eric Rescorla (:ekr)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9958b17acc01

Comment 5

[Eric Rescorla (:ekr)]

Attachment: Fix unit tests to match fix to MediaPipeline

Comment 6

[Eric Rescorla (:ekr)]

Comment on attachment 698322 [details] [diff] [review]
Fix unit tests to match fix to MediaPipeline

Forget to change the unit tests. Also a bit of trivial reformatting

Comment 7

[Eric Rescorla (:ekr)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1b88be2c5e1f

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9958b17acc01

Comment 9

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/1b88be2c5e1f