825635 - Volume control stops working in FM when headset is unplugged and plugged

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P3)

Description

[John Hopkins (:jhopkins)]

The volume control stops working after following these steps:

1) Boot up the phone
2) Start the FM radio
3) Plug in a headset
4) Listen to the radio for a moment and adjust volume (note: volume actually changes)
5) Unplug the headset
6) Plug the headset back in
7) Adjust the volume and note that it does not result in a volume change any longer.

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

I think this is more like a platform bug. Redirect to Randy.

It seems when FM is changing its state, the audio-channel-changed is not fired at step(7).

Comment 2

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: fix-patch1

If FM radio turn off, the mCurrentHigherChannel would keep in AUDIO_CHANNEL_CONTENT,so if the next FM radio turning on, the getMuted function wouldn't broadcast audio channel change, cause by this statement:higher == mCurrentHigherChannel == AUDIO_CHANNEL_CONTENT.

Music isn't has this problem. I found the getMuted would check normal channel first and that would replace mCurrentHigherChannel value. then check CONTENT channel again.

Comment 4

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: checkin-patch

check in patch

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4dbb2c7bc4d0

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4dbb2c7bc4d0

Comment 7

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

This patch needs to phase in b2g-18 trunk.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4c19058bfc3b
https://hg.mozilla.org/releases/mozilla-b2g18/rev/a07bf4dcb8e6

Comment 10

[Cody Roesch [:croesch]]

In Unagi build 20130125070201 Version 18.0 This bug is still occurring. If I turn the radio on then press the power button to make the screen dark, The Hardware volume buttons are not reliable. I was able to turn the volume down but could not turn the volume back up.

I've already written a bug about it but it was duped and I know people hate reopening bugs. So I'll just comment and leave it up to the powers that be.

I'm running Testrun 3 and it fails testcase https://moztrap.mozilla.org/runtests/run/702/env/296/?pagenumber=1&pagesize=20&sortfield=order&sortdirection=asc&filter-id=3933&filter-suite=168

Build ID: 20130125070201
Kernel: Dec 5

Comment 11

[Cody Roesch [:croesch]]

Additional info
Gecko:  http://hg.mozilla.org/releases/mozilla-b2g18/rev/94a2d6fcdfde
Gaia:   6369dbf33b622faf4b4d176fed30b77c5c319dfc