Closed Bug 825730 Opened 7 years ago Closed 7 years ago

Various SVG cleanups

Categories

(Core :: SVG, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Details

Attachments

(3 files)

No description provided.
Attachment #696859 - Flags: review?(longsonr)
Attachment #696861 - Flags: review?(longsonr)
Attachment #696859 - Flags: review?(longsonr) → review+
Comment on attachment 696860 [details] [diff] [review]
Add a more convenient signature for ToDOMAnimatedLength

> {
>-  nsCOMPtr<nsIDOMSVGAnimatedLength> cx;
>-  mLengthAttributes[CX].ToDOMAnimatedLength(getter_AddRefs(cx), this);
>-  return cx.forget();
>+  return mLengthAttributes[ATTR_CX].ToDOMAnimatedLength(this);

Does this compile? What's changing CX to ATTR_CX?

This occurs 2 or 3 other times

r=longsonr if it compiles.
Attachment #696860 - Flags: review?(longsonr) → review+
Comment on attachment 696861 [details] [diff] [review]
Include headers as mozilla/dom

I assume this depends on other patches elsewhere. Do make sure it compiles when it lands.
Attachment #696861 - Flags: review?(longsonr) → review+
(In reply to Robert Longson from comment #4)
> Comment on attachment 696860 [details] [diff] [review]
> Add a more convenient signature for ToDOMAnimatedLength
> 
> > {
> >-  nsCOMPtr<nsIDOMSVGAnimatedLength> cx;
> >-  mLengthAttributes[CX].ToDOMAnimatedLength(getter_AddRefs(cx), this);
> >-  return cx.forget();
> >+  return mLengthAttributes[ATTR_CX].ToDOMAnimatedLength(this);
> 
> Does this compile? What's changing CX to ATTR_CX?
> 
> This occurs 2 or 3 other times
> 
> r=longsonr if it compiles.

I changed those when adding the WebIDL bindings because having X be both in the enum and a function doesn't compile too well.  These patches compile but they're interspersed with other patches in my queue so I'll land them together.
https://hg.mozilla.org/mozilla-central/rev/2a2a7a9d4d3e
https://hg.mozilla.org/mozilla-central/rev/04e417ee3fe8
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.