Closed Bug 825739 Opened 11 years ago Closed 6 years ago

Intermittent browser_bookmark_titles.js | Exception thrown - [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavBookmarksService.getItemTitle]

Categories

(Firefox :: Bookmarks & History, defect, P3)

Product:
Firefox
Component:
Bookmarks & History
Platform:
All
Windows XP
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: graememcc, Assigned: standard8)

References

Details

(Keywords: intermittent-failure, Whiteboard: [test disabled on Windows])

Attachments

(2 files)

patch v1.0
2.72 KB, patch
asaf
: review+
Details | Diff | Splinter Review
Bug 825739 - Re-enable browser_bookmark_titles.js on Windows as the intermittents seem to have gone away.
59 bytes, text/x-review-board-request
mak
: review+
Details 
https://tbpl.mozilla.org/php/getParsedLog.php?id=18377220&tree=Mozilla-Inbound
Rev3 WINNT 5.1 mozilla-inbound opt test mochitest-browser-chrome
s: talos-r3-xp-007


TEST-START | chrome://mochitests/content/browser/browser/base/content/test/browser_bookmark_titles.js
TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_bookmark_titles.js | Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.com/browser/browser/base/content/test/dummy_page.html" line: 0}]
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_bookmark_titles.js | Exception thrown - [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavBookmarksService.getItemTitle]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: chrome://mochitests/content/browser/browser/base/content/test/browser_bookmark_titles.js :: checkBookmark :: line 69"  data: no]
INFO TEST-END | chrome://mochitests/content/browser/browser/base/content/test/browser_bookmark_titles.js | finished in 279ms
Assignee: nobody → mak77
Attached patch patch v1.0 — — Splinter Review 
testing this on Try.

The first problem may be due to about:blank loading, but I also found a local problem with using a non existing url, my provider redirects in such a case and thus the test may always fail for some devs. In general better not even try to access the network from tests.
Comment on attachment 705121 [details] [diff] [review]
patch v1.0

Try is happy so far, though it's hard to tell if it fixes the intermittent failure. won't hurt.
Attachment #705121 - Flags: review?(mano)
Attachment #705121 - Flags: review?(mano) → review+
https://hg.mozilla.org/mozilla-central/rev/35e0c12f4332
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
ok, looks like the test using DOMContentLoaded like this is fragile, it ends up bookmarking "something else".
(In reply to Marco Bonardo [:mak] from comment #11)
> ok, looks like the test using DOMContentLoaded like this is fragile, it ends
> up bookmarking "something else".

Marco, can you take another look at this? :-)
Seems to have become particularly frequent in the last week or so.
Flags: needinfo?(mak77)
Whiteboard: [disable-me 2013-04-01]
Mano, could you please take a look at this? my suspect is that the DOMContentLoaded listener in the test is not good enough to ensure bookmarkCurrentPage is actually bookmarking the expecte page, it ends up bookmarking a previous entry and then tries to access bookmark for the expected page, that clearly doesn't exist.
Assignee: mak77 → mano
Status: REOPENED → ASSIGNED
Flags: needinfo?(mak77) → needinfo?(mano)
Mano, please can you take a look at this frequent orange?
I think it's getting to be disabling time here.
Flags: needinfo?(mano) → needinfo?(mak77)
Whiteboard: [disable-me 2013-04-01]
I'm sorry but I couldn't find anything wrong from the logging, there's something escaping my eyes.
Flags: needinfo?(mak77)
Assignee: asaf → nobody
Status: ASSIGNED → NEW
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
I've just run this through try server, and this had approx 50 runs per Win32/64 opt/debug without any failures.

If nothing else fixed it, I suspect some of the changes to async code have helped.

Therefore, lets try re-enabling this on the trees and see what happens.
Assignee: nobody → standard8
Comment on attachment 8952985 [details]
Bug 825739 - Re-enable browser_bookmark_titles.js on Windows as the intermittents seem to have gone away.

https://reviewboard.mozilla.org/r/222250/#review228214

Worth a try.
Attachment #8952985 - Flags: review?(mak77) → review+
Whiteboard: [test disabled on Windows][leave open] → [test disabled on Windows]
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e1524438c372
Re-enable browser_bookmark_titles.js on Windows as the intermittents seem to have gone away. r=mak
https://hg.mozilla.org/mozilla-central/rev/e1524438c372
Status: NEW → RESOLVED
Closed: 11 years ago → 6 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: Firefox 21 → Firefox 60
You need to log in before you can comment on or make changes to this bug.