825749 - Convert SVG gradient elements to WebIDL

Status: RESOLVED FIXED

(Core :: SVG, defect)

Comment 1

[David Zbarsky (:dzbarsky)]

I've been avoiding subclasses of SVGDefinitionElement until the WG decides which elements SVGTests should actually be implemented on.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Looks like we already implement SVGTests on those, so I just kept it.

Comment 3

[Robert Longson [:longsonr]]

The trouble is that the current SVG Specification says both that SVGTests should and shouldn't work on gradients in different sections. The most likely outcome is that SVGTests will get removed from gradients, patterns, filters and clipPaths.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Robert Longson from comment #3)
> The trouble is that the current SVG Specification says both that SVGTests
> should and shouldn't work on gradients in different sections. The most
> likely outcome is that SVGTests will get removed from gradients, patterns,
> filters and clipPaths.

Sure. But AFAICT, we currently support SVGTests on gradients, and I have no intention of changing that in this bug.

Comment 5

[Robert Longson [:longsonr]]

(In reply to :Ms2ger from comment #4)
> 
> Sure. But AFAICT, we currently support SVGTests on gradients, and I have no
> intention of changing that in this bug.

We do, I'm planning to change it in bug 825411 as soon as Cameron confirms that's what should happen.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 696993 [details] [diff] [review]
Patch v1

> /* readonly attribute nsISupports gradientTransform; */

Fix the comment?

>+/* readonly attribute nsIDOMSVGAnimatedLength cx; */
>+NS_IMETHODIMP SVGLinearGradientElement::GetX1(nsIDOMSVGAnimatedLength * *aX1)

Unbreak the comment?

>+/* readonly attribute nsIDOMSVGAnimatedLength cy; */
>+NS_IMETHODIMP SVGLinearGradientElement::GetY1(nsIDOMSVGAnimatedLength * *aY1)

Likewise.

>+/* readonly attribute nsIDOMSVGAnimatedLength rx; */
>+NS_IMETHODIMP SVGLinearGradientElement::GetX2(nsIDOMSVGAnimatedLength * *aX2)

And here.

>+/* readonly attribute nsIDOMSVGAnimatedLength ry; */
>+NS_IMETHODIMP SVGLinearGradientElement::GetY2(nsIDOMSVGAnimatedLength * *aY2)

And here.

r=me with those comment fixes

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/84ad8539acfd