Convert SVG gradient elements to WebIDL

RESOLVED FIXED in mozilla21

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla21
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
I've been avoiding subclasses of SVGDefinitionElement until the WG decides which elements SVGTests should actually be implemented on.
(Assignee)

Comment 2

6 years ago
Created attachment 696993 [details] [diff] [review]
Patch v1

Looks like we already implement SVGTests on those, so I just kept it.
Attachment #696993 - Flags: review?(bzbarsky)
The trouble is that the current SVG Specification says both that SVGTests should and shouldn't work on gradients in different sections. The most likely outcome is that SVGTests will get removed from gradients, patterns, filters and clipPaths.
Depends on: 825411
(Assignee)

Comment 4

6 years ago
(In reply to Robert Longson from comment #3)
> The trouble is that the current SVG Specification says both that SVGTests
> should and shouldn't work on gradients in different sections. The most
> likely outcome is that SVGTests will get removed from gradients, patterns,
> filters and clipPaths.

Sure. But AFAICT, we currently support SVGTests on gradients, and I have no intention of changing that in this bug.
(In reply to :Ms2ger from comment #4)
> 
> Sure. But AFAICT, we currently support SVGTests on gradients, and I have no
> intention of changing that in this bug.

We do, I'm planning to change it in bug 825411 as soon as Cameron confirms that's what should happen.
Comment on attachment 696993 [details] [diff] [review]
Patch v1

> /* readonly attribute nsISupports gradientTransform; */

Fix the comment?

>+/* readonly attribute nsIDOMSVGAnimatedLength cx; */
>+NS_IMETHODIMP SVGLinearGradientElement::GetX1(nsIDOMSVGAnimatedLength * *aX1)

Unbreak the comment?

>+/* readonly attribute nsIDOMSVGAnimatedLength cy; */
>+NS_IMETHODIMP SVGLinearGradientElement::GetY1(nsIDOMSVGAnimatedLength * *aY1)

Likewise.

>+/* readonly attribute nsIDOMSVGAnimatedLength rx; */
>+NS_IMETHODIMP SVGLinearGradientElement::GetX2(nsIDOMSVGAnimatedLength * *aX2)

And here.

>+/* readonly attribute nsIDOMSVGAnimatedLength ry; */
>+NS_IMETHODIMP SVGLinearGradientElement::GetY2(nsIDOMSVGAnimatedLength * *aY2)

And here.

r=me with those comment fixes
Attachment #696993 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 7

6 years ago
https://hg.mozilla.org/mozilla-central/rev/84ad8539acfd
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.