825762 - Bluetooth file transfer failure depending on filename

Status: VERIFIED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[:gerard-majax]

File transfer over bluetooth seems to fail depending on the filename being transferred. I reproduced it between Ubuntu (12.10) and Firefox OS running on Nexus S.

Gecko @ 49bd828
Gaia @ fb5880d

$ sha1sum Capture*
8a94b4eec65c6c7fbc9cc5cd94b5dd2a69ce3dde  Capture du 2012-12-30 21:20:35.png  => failure 0x41
8a94b4eec65c6c7fbc9cc5cd94b5dd2a69ce3dde  Capture_du_2012-12-30_21:20:35.png  => failure 0x41
8a94b4eec65c6c7fbc9cc5cd94b5dd2a69ce3dde  Capture_du_2012-12-30_212035.png    => OK
8a94b4eec65c6c7fbc9cc5cd94b5dd2a69ce3dde  Capture_du_20121230_212035.png      => OK

The presence of ':' (at least, not checked everything) seems to make the transfer failing with error 0x41.

Comment 1

[:gerard-majax]

I think it's basically because VFAT does not allows ':' in filenames.

Comment 2

[:gerard-majax]

Please see:
vfat_bad_char() at http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=fs/fat/namei_vfat.c;h=ac959d655e7d7f7dd92448437b58ec4fe81ce1ab;hb=HEAD#l193

Comment 3

[Walter Chen[:ypwalter][:wachen]]

: is one of the character that causing the failure of this.
I also tried to include like ~!@#$%^&* in a file. It would make the bluetooth file transferring failed.

Comment 4

[Walter Chen[:ypwalter][:wachen]]

CC. Gina Yeh and Eric Chou for them to look into this issue when they have free time.

Comment 5

[Eric Chou [:ericchou] [:echou]]

Confirmed. I'll take it.

Comment 6

[Joe Cheng [:jcheng] (please needinfo)]

Triage: BB-, tracking-b2g18+. this seems to be more of a case with transferring files from a computer. Phone to phone file transfer should be ok (given that you would have problem loading files with special file names into the SD in the first place)

Comment 7

[:gerard-majax]

Would it be THAT hard to just have a better error message, or best, when receiving the file and prompting the user for permission notifying that it contains characters that cannot be used on vfat ?

Comment 8

[Walter Chen[:ypwalter][:wachen]]

(In reply to Alexandre LISSY :gerard-majax from comment #7)
> Would it be THAT hard to just have a better error message, or best, when
> receiving the file and prompting the user for permission notifying that it
> contains characters that cannot be used on vfat ?

I don't think that would be a issue having a better error message or other actions. However, it might not be the most urgent thing to handle. In that case, it's bb-. 

Also, Eric Chou told us that he would take that. To my best understanding, he would fix bug really fast or at least at a good care of it.

Comment 9

[Walter Chen[:ypwalter][:wachen]]

*or at least "take" good care of it.

Comment 10

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v1: replace invalid chars in filename of received files

* Replace VFAT reserved characters with '_' to avoid transferring failed. Please see the link below for more information about the list of reserved characters.

http://msdn.microsoft.com/en-us/library/windows/desktop/aa365247%28v=vs.85%29.aspx

Comment 11

[Eric Chou [:ericchou] [:echou]]

More info: http://en.wikipedia.org/wiki/Filename

Comment 12

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v2: replace invalid chars in filename of received files

* fix typo

Comment 13

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 701053 [details] [diff] [review]
patch 1: v2: replace invalid chars in filename of received files

Review of attachment 701053 [details] [diff] [review]:
-----------------------------------------------------------------

There might be cleaner ways to express the reserved char check, but this is important enough that I'm not going to block it on that.

Comment 14

[Eric Chou [:ericchou] [:echou]]

try: https://tbpl.mozilla.org/?tree=Try&rev=c7211cb41418

Comment 15

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/09f24f14e290

Comment 16

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/09f24f14e290

Comment 17

[Eric Chou [:ericchou] [:echou]]

Nominate as tef?

Rationale:
Without this patch, we are unable to receive a file with characters such as ?:[]<>|
In addition, it won't affect the logic of file transfer, only a name check function call will be inserted in the middle of the receiving file process.

Comment 18

[Eric Chou [:ericchou] [:echou]]

(In reply to Eric Chou [:ericchou] [:echou] from comment #17)
> Nominate as tef?
> 
> Rationale:
> Without this patch, we are unable to receive a file with characters such as
> ?:[]<>|

Sorry for the unclear description, I meant "unable to receive a file with these characters in its file name"

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/3b355e2a9351

Comment 20

[Walter Chen[:ypwalter][:wachen]]

Verified fixed in 2013-01-20-07-02-02 pvt nightly b2g18 build.

This patch would change anything that might causing crashes, like ?:[]<>| to _ before starting to transferring.

Comment 21

[Lukas Blakk [:lsblakk] use ?needinfo]

Landed on mozilla-b2g18/gaia master prior to the 1/25 branching to mozilla-b2g18_v1_0_0/v1.0.0, updating status-b2g-v1.0.0 to fixed.