825809 - mWaitingForContentToPaint should be true after mPaintThrottler.TaskComplete post new task

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Oleg Romashin (:romaxa)]

I've found one problem with mWaitingForContentToPaint and 
http://mxr.mozilla.org/mozilla-central/source/gfx/layers/ipc/AsyncPanZoomController.cpp#1156

Basically we have case when RequestContentRepaint posted but not tracked by mWaitingForContentToPaint.
this happen when we call mPaintThrottler.TaskComplete which Run queued task, and do not set mWaitingForContentToPaint = true in that case.

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Track waiting for task executed in TaskComplete

Comment 2

[Oleg Romashin (:romaxa)]

Btw, this patch fixes content shaking during scroll with FLING

Comment 3

[Oleg Romashin (:romaxa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/97d2ac9d16c4

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Is this a patch we should track for uplifting to b2g18?

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/97d2ac9d16c4

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

We'll track, please nominate for approval with reasons for uplift and risk assessment.

Comment 7

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Comment on attachment 696928 [details] [diff] [review]
Track waiting for task executed in TaskComplete

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 799401
User impact if declined: Unpainted (white) regions on screen.
Testing completed: Has been on m-c for some time.
Risk to taking this patch (and alternatives if risky): Low. The bug was a clear oversight that missed an edge case.
String or UUID changes made by this patch: None.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/939f725e4ca8