Closed
Bug 825818
Opened 12 years ago
Closed 12 years ago
Fix six -Wlogical-op-parentheses warnings in nsUTF8ToUnicode.cpp.
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.85 KB,
patch
|
emk
:
review+
|
Details | Diff | Splinter Review |
clang 3.2 warns:
intl/uconv/src/nsUTF8ToUnicode.cpp:274:27 [-Wlogical-op-parentheses] '&&' within '||'
intl/uconv/src/nsUTF8ToUnicode.cpp:274:38 [-Wlogical-op-parentheses] '&&' within '||'
intl/uconv/src/nsUTF8ToUnicode.cpp:275:47 [-Wlogical-op-parentheses] '&&' within '||'
intl/uconv/src/nsUTF8ToUnicode.cpp:276:27 [-Wlogical-op-parentheses] '&&' within '||'
intl/uconv/src/nsUTF8ToUnicode.cpp:276:38 [-Wlogical-op-parentheses] '&&' within '||'
intl/uconv/src/nsUTF8ToUnicode.cpp:277:49 [-Wlogical-op-parentheses] '&&' within '||'
|
Assignee | |
Comment 1•12 years ago
|
||
This patch fixes that by adding the appropriate parentheses. I haven't changed
the meaning of the code, because it looks (to my untrained eye) like it's
currently correct.
The patch also fixes the Emacs/vim modelines to match that requested in
https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style, and
removes trailing whitespace from one line.
Attachment #696941 -
Flags: review?(VYV03354)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 696941 [details] [diff] [review]
Fix six -Wlogical-op-parentheses warnings in nsUTF8ToUnicode.cpp.
r=me assuming this patch passed the tests.
Attachment #696941 -
Flags: review?(VYV03354) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Blocks: buildwarning
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•