825841 - B2G RIL: not sendSyncMessage("RIL:GetRilContext") in constructor

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

We now send an IPC message 'RIL:GetRilContext' in the constructor of RILContentHelper but we shouldn't do that (or need to improve it) for the following reasons IMO:
1) in RadioInterfaceLayer, 'RIL:GetRilContext' message should be sent from a content process with 'mobileconnection' permission, but we don't guarantee the privilege in RILContentHelper that might cause the content process without that permission being killed.
2) Content processes with various permissions may get service of RILContentHelper. It's not a good idea that we do something specific to a particular privilege in the constructor.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: Patch

Not sending RIL:GetRilContext message in RILContentHelper constructor, sending it when we first time require the info instead.

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 699031 [details] [diff] [review]
Patch

Review of attachment 699031 [details] [diff] [review]:
-----------------------------------------------------------------

;) Then we have to modify existing MultiSIM code as well though.

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #2)
> Comment on attachment 699031 [details] [diff] [review]
> Patch
> 
> Review of attachment 699031 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ;) Then we have to modify existing MultiSIM code as well though.

Definitely!

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2d3df85c7174

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2d3df85c7174