Closed Bug 826024 Opened 7 years ago Closed 7 years ago

[DeviceStorage]: don't treat .m4v files as music

Categories

(Core :: DOM: Device Interfaces, defect)

18 Branch
x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: djf, Assigned: dougt)

Details

Attachments

(1 file)

toolkit/content/devicestorage.properties (or whatever the file is) says that .m4v files are a kind of music.

.m4v files are a .mp4 container, and the 'v' in the extension refers to videos. Gecko's audio element will actually attempt to play these as audio, but I believe that only videos get saved with this extension.

It would be better if device storage did not return these as music files.
Assignee: nobody → doug.turner
Attached patch patch v.1Splinter Review
Attachment #697182 - Flags: review?(dflanagan)
Comment on attachment 697182 [details] [diff] [review]
patch v.1

Review of attachment 697182 [details] [diff] [review]:
-----------------------------------------------------------------

That was quick!  Thanks.
Attachment #697182 - Flags: review?(dflanagan) → review+
Attachment #697182 - Flags: approval-mozilla-b2g18?
Attachment #697182 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/013dae0ca576
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
(In reply to Doug Turner (:dougt) from comment #3)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/013dae0ca576

Sorry if this is a silly question, but shouldn't m4v be placed in the videos row in that case?
Not a silly question at all. I assumed that it was already on that line... Doug, what do you think?
Attachment #697182 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Is this still requesting approval for B2G? Not clear if we're going to address Comment 5 (or what would happen if we didn't).
Comment on attachment 697182 [details] [diff] [review]
patch v.1

still waiting on comment 5 - minusing the approval request since it seems like we do not need this.
Attachment #697182 - Flags: approval-mozilla-b2g18? → approval-mozilla-b2g18-
You need to log in before you can comment on or make changes to this bug.