826024 - [DeviceStorage]: don't treat .m4v files as music

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[David Flanagan [:djf]]

toolkit/content/devicestorage.properties (or whatever the file is) says that .m4v files are a kind of music.

.m4v files are a .mp4 container, and the 'v' in the extension refers to videos. Gecko's audio element will actually attempt to play these as audio, but I believe that only videos get saved with this extension.

It would be better if device storage did not return these as music files.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[David Flanagan [:djf]]

Comment on attachment 697182 [details] [diff] [review]
patch v.1

Review of attachment 697182 [details] [diff] [review]:
-----------------------------------------------------------------

That was quick!  Thanks.

Comment 3

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/013dae0ca576

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/013dae0ca576

Comment 5

[Alex Keybl [:akeybl]]

(In reply to Doug Turner (:dougt) from comment #3)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/013dae0ca576

Sorry if this is a silly question, but shouldn't m4v be placed in the videos row in that case?

Comment 6

[David Flanagan [:djf]]

Not a silly question at all. I assumed that it was already on that line... Doug, what do you think?

Comment 7

[Alex Keybl [:akeybl]]

Is this still requesting approval for B2G? Not clear if we're going to address Comment 5 (or what would happen if we didn't).

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 697182 [details] [diff] [review]
patch v.1

still waiting on comment 5 - minusing the approval request since it seems like we do not need this.