Closed Bug 826028 Opened 9 years ago Closed 9 years ago

Add a simple embed mode

Categories

(Tree Management Graveyard :: TBPL, defect)

Product:
Tree Management Graveyard
Component:
TBPL
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: BenWa, Assigned: BenWa)

References

Details

Attachments

(1 file, 1 obsolete file)

patch
1.01 KB, patch
BenWa
: review+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — — Splinter Review 
This adds support for ?embed which is used to put TBPL in an iframe from another origin where I can't simply hide the topbar.

I have a patch to bugzillaJS to add inline iframe with TBPL results but the topbar takes valuable space.
Attachment #697155 - Flags: review?(edmorley.bz)
Comment on attachment 697155 [details] [diff] [review]
patch

Worth also reducing #container's padding?
Attachment #697155 - Flags: review?(edmorley.bz) → review+
Attached patch patch — — Splinter Review 
Padding down to 2px
Attachment #697155 - Attachment is obsolete: true
Attachment #697604 - Flags: review+
I'm still waiting on the pull from bugzillaJS but I've started using this locally. What's the procedure for deploying changes to TBPL?

https://dl.dropbox.com/u/10523664/Screenshots/86.png
tbpl-dev.allizom.org updates directly from the hg repo on a 15 min cron, credentials at:
https://intranet.mozilla.org/Websites/Stage_Passwords#TBPL

Once all looks good, see bug 823926 for example push to prod request :-)
Depends on: 829149
In production :-)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee: nobody → bgirard
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.