826055 - mp3 link does absolutely nothing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Josh Matthews [:jdm]]

STR:
1. visit http://ccmixter.org/files/texasradiofish/40632 in the browser
2. press the "Download" link, and play around with the window that pops up until you are able to press the link to the mp3 file (http://ccmixter.org/content/texasradiofish/texasradiofish_-_Waiting_for_You.mp3)
3. Notice that nothing happens. Open it in a new tab, and the page apparently loads and is blank.

Expected:
Some kind of download request, or sending it to the music app or something.

Actual:
Nothing. The same link on desktop opens up the download request dialog.

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

Triage: this is currently working as expected for V1 but should probably have a nicer message instead of loading a blank page. BB-, tracking-b2g18+

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Check OMX when looking for decoders on FirefoxOS

I triggered this bug a few days ago and was able to fix it. The problem is that Gecko doesn't check the OMX framework, which handles MP3 files on FirefoxOS. The attached patch fixes the problem and allows for streaming of MP3 files within the browser app.

I noticed that there are other types that are not not handled as well (e.g., wave files). Is this intentionally or just missing?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 705377 [details] [diff] [review]
Check OMX when looking for decoders on FirefoxOS

r=me, though it's not clear to me why all this stuff is ifdefed.  Seems like it would be better to keep the ifdefs inside DecoderTraits, no?  Please file a followup bug on that.

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Check OMX when looking for decoders on FirefoxOS

Added [r=bzbarsky]

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a6017827ba0

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8a6017827ba0

Comment 7

[Ryan VanderMeulen [:RyanVM]]

This bug is marked tracking+ for b2g18. However, the patch does not apply cleanly enough for uplift. Please post a branch-specific patch. Thanks!

Comment 8

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Reopened for uplift.

Comment 9

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Check OMX when looking for decoders on FirefoxOS (b2g18)

The patch for b2g18. No actual code changes have been made.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/0f3decb05b30

Please don't reopen bugs for uplifts. The resolution is used to track landing on mozilla-central. We use the status flags to track uplifts and reopening the bug can cause it to be missed when we're looking for uplifts.