826074 - Update terminology for customizing about:home

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

We currently just use the world "Edit", "Clear", and "Clear All" for editing sites on about:home. This is a bit confusing for a UI that is (currently) basically just pinning and unpinning sites. We only show Clear on sites that are pinned (you can't clear sites that you just don't want to see on about:home), and only show Clear All if any of the sites are pinned (but not necessarily the one you long tapped on).

This is a bit confusing to users who might want to remove a site from our frecent list, or think editing will remove a particular site (it won't if its not a pinned site). Seems like it would be better to use something like "Pin Site", "Unpin Site", "Unpin all" and maybe "Change Pinned Site".

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

This updates the strings to "Pin Site" "Unpin Site", and "Unpin All". I left "Edit" in on ibarlow's advice. "Pin Site" will pin whatever is already in that slot (i.e. its a fast path of sorts). We definitely need an indicator to make that more obvious that something happened in that case. Hopefully coming tomorrow.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 697537 [details] [diff] [review]
Patch

clearSite() -> unpinSite()
clearAllSites() -> unpinAllSites()

Just to make things more clear

r+ with that

Comment 3

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d119006ec64

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9d119006ec64

Comment 5

[Andreea Pod]

Verified fixed on:
-build:  Firefox for Android 21.0a1 (2013-02-15)
-device: Samsung Galaxy Nexus
-OS: Android 4.2.1