Closed Bug 826120 Opened 7 years ago Closed 7 years ago

mach's warning parser is confused by some gcc 4.6 warning messages containing '[' chars

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set

Tracking

(firefox19 wontfix, firefox20 fixed)

RESOLVED FIXED
mozilla20
Tracking Status
firefox19 --- wontfix
firefox20 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

Details

Attachments

(1 file)

When parsing "warning: (near initialization for 'full_wmonthname[0]') [-Wpointer-sign]", mach thinks the warning name is "0" instead of "-Wpointer-sign".

I added a test case to test_warnings.py, but I couldn't find any instructions on how to actually run the mach unit tests. <:)
Attachment #697268 - Flags: review?(gps)
Assignee: nobody → cpeterson
Status: NEW → ASSIGNED
Comment on attachment 697268 [details] [diff] [review]
mach-warnings.patch

Review of attachment 697268 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #697268 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/e0ecff0cf5ee
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.