mach's warning parser is confused by some gcc 4.6 warning messages containing '[' chars

RESOLVED FIXED in Firefox 20

Status

RESOLVED FIXED
6 years ago
8 months ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

Trunk
mozilla20
x86
Mac OS X

Firefox Tracking Flags

(firefox19 wontfix, firefox20 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 697268 [details] [diff] [review]
mach-warnings.patch

When parsing "warning: (near initialization for 'full_wmonthname[0]') [-Wpointer-sign]", mach thinks the warning name is "0" instead of "-Wpointer-sign".

I added a test case to test_warnings.py, but I couldn't find any instructions on how to actually run the mach unit tests. <:)
Attachment #697268 - Flags: review?(gps)
(Assignee)

Updated

6 years ago
Assignee: nobody → cpeterson
Status: NEW → ASSIGNED

Comment 1

6 years ago
Comment on attachment 697268 [details] [diff] [review]
mach-warnings.patch

Review of attachment 697268 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #697268 - Flags: review?(gps) → review+
(Assignee)

Comment 2

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0ecff0cf5ee
status-firefox19: --- → wontfix
status-firefox20: --- → fixed
Target Milestone: --- → mozilla20
https://hg.mozilla.org/mozilla-central/rev/e0ecff0cf5ee
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.