826125 - Show up some removed history in location bar.

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, defect)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

[Environment]
* Nightly 20, http://hg.mozilla.org/mozilla-central/rev/a812ef63de87
* Intel Mac OS X 10.8

[STR]
0. Clean profile
1. Open the google's search page with input some word in search-bar.
2. Remove (1)'s history from history panel.
3. Type 'google' in location bar.

[Result]
Show up the entry which is removed in (2).

Comment 1

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

The similar bug which has been fixed: Bug 773982

Comment 2

[Marco Bonardo [:mak]]

if you search for "google" in the sidebar, you should see both entries to be removed.
Bug 773982 is showing hidden entries _when searching_, not by default, so if you open the history sidebar and don't search for the entry you want to remove you won't see all the entries.
The idea is that you want to get rid of "google" from the locationbar, open the history sidebar (or the Library), search for "google" and remove entries. Searching manually through a list is a less interesting use-case considered size of history.

Comment 3

[Marco Bonardo [:mak]]

does comment 2 help?

Comment 4

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

I'm sorry for replying the comment.

The behavior which I found is following:

1: On nightly, search "google" from search bar.
* Browser may try to open "https://www.google.com/...". But it really open "https://www.google.co.jp/..." when I search from Japan.
2: Open the history sidebar, the sidebar show up (1)'s history. It is the entry which is begun from "https://www.google.co.jp/...".  But there is no "https://www.google.com/..." one.
3: If I have removed the entry of "https://www.google.co.jp/..." on sidebar, The URI of "https://www.google.co.jp/..." is not shown on any places (include location bar, Places-Library, History Sidebar Panel).
4: But the URI entry of "https://www.google.com/..." will be shown in location bar search after (3).
**Extra**: Some shorten URIs might behave like above. But I can't get more certain step to reproduce now.

From these behaviors, I seem that the history sidebar panel cannot handle some redirection URIs well.

Marco, Does this comment help you to decide this bug status?

Comment 5

[Marco Bonardo [:mak]]

(In reply to Tetsuharu OHZEKI [:saneyuki_s] from comment #4)
> 1: On nightly, search "google" from search bar.
> * Browser may try to open "https://www.google.com/...". But it really open
> "https://www.google.co.jp/..." when I search from Japan.

ok, basically it redirects to the local version

> 2: Open the history sidebar, the sidebar show up (1)'s history. It is the
> entry which is begun from "https://www.google.co.jp/...".  But there is no
> "https://www.google.com/..." one.

Expected, cause we hide redirect sources in history views

> 3: If I have removed the entry of "https://www.google.co.jp/..." on sidebar,
> The URI of "https://www.google.co.jp/..." is not shown on any places
> (include location bar, Places-Library, History Sidebar Panel).

right, but the google.com/ entry still exists

> 4: But the URI entry of "https://www.google.com/..." will be shown in
> location bar search after (3).

yep, though if you _search_ for "google" in the sidebar or the Library you should find the google.com entry there and be able to remove it.

The current behavior is that redirect sources are hidden from history views until you are actively searching for something, the scope is to reduce clutter and make visible results more useful (it's what you saw while browsing) while still allowing to cleanup history from certain entries through search.

Comment 6

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

(In reply to Marco Bonardo [:mak] (Away Feb 22) from comment #5)
> yep, though if you _search_ for "google" in the sidebar or the Library you
> should find the google.com entry there and be able to remove it.

YES! I confirmed it now!

> The current behavior is that redirect sources are hidden from history views
> until you are actively searching for something, the scope is to reduce
> clutter and make visible results more useful (it's what you saw while
> browsing) while still allowing to cleanup history from certain entries
> through search.

Thank you for account. I'll close this bug.

Comment 7

[Marco Bonardo [:mak]]

Thanks.  I admit the new behavior may look confusing at first, I'm not totally sold on it, so I'll take a look at feedback for the next releases.