826159 - Cookie Manager doesn't display non-ASCII cookie values correctly

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[Masatoshi Kimura [:emk]]

Steps to reproduce:
1. Open the URL.
2. View the Cookie value from Options > Privacy > remove individual cookies.
3. Open the Web Console and type and type |document.cookie|.
4. Compare both values.

Actual result:
The former value contains 'utmccn=Some%20Name%20â%202013' while the latter contains 'utmccn=Some%20Name%20–%202013'.

Expected result:
Both values should be the same (have 'utmccn=Some%20Name%20–%202013').

Comment 1

[Masatoshi Kimura [:emk]]

Actually this was a Core issue.
https://mxr.mozilla.org/mozilla-central/source/netwerk/cookie/nsICookie.idl?rev=a16372ce30b5&mark=29-29#19
>    readonly attribute ACString value;
should be
     readonly attribute AUTF8String value;
.

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: patch

Comment 3

[Masatoshi Kimura [:emk]]

Attachment: patch v2

The previous patch failed on tinderbox because it was affected by other tests setting cookie.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 697407 [details] [diff] [review]
patch v2

r=me

Comment 5

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5029e7c89abd

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5029e7c89abd