826177 - [DIALER] Should keep signalling the call waiting until the user act on it

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P3)

Description

[Walter Chen[:ypwalter][:wachen]]

2013-1-2 b2g18(v1.0) build from pvt server

STR:
  0. Call B2G device from other phone, and pick up it.
  1. Call B2G device from another phone

expected result: 
  the phone shows incoming call from another phone and have sound notification

actual result:
  the phone shows incoming call but doesn't have sound notification

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

Triage: BB+, P3, C4 - this is making call waiting basically not working (unless you are looking at the screen)

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Randy or Macro, if you have solutions in platform side, you could take it and change the component.
For gaia side solution: enforce vibration when call is incoming.

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

adding Josh to have UX consideration here as well

Comment 4

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Do the dialer playback the dudu sound as the call waiting tone?

Comment 5

[Walter Chen[:ypwalter][:wachen]]

(In reply to Randy Lin [:rlin] from comment #4)
> Do the dialer playback the dudu sound as the call waiting tone?

No. The answer is no.

Comment 6

[Etienne Segonzac (:etienne)]

Alive, can I steal this?

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Etienne Segonzac (:etienne) from comment #6)
> Alive, can I steal this?
Welcome! :)

Comment 8

[Etienne Segonzac (:etienne)]

(In reply to Alive Kuo [:alive] from comment #2)
> For gaia side solution: enforce vibration when call is incoming.

The phone is already vibrating when a second call is incoming, are you talking about making it longer? (ie. as long as the second call is waiting)

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Etienne Segonzac (:etienne) from comment #8)
> (In reply to Alive Kuo [:alive] from comment #2)
> > For gaia side solution: enforce vibration when call is incoming.
> 
> The phone is already vibrating when a second call is incoming, are you
> talking about making it longer? (ie. as long as the second call is waiting)

I haven't investigated on this..if there's already a vibration I think it's O.K.
Something need to be clarified:
* Is the DuDu sound pronounced by Telephony? Or an audio tag?
* When second call coming, do we need to let the ringer sound again? How? Because ringer priority is less than voice-call now..

Comment 10

[Etienne Segonzac (:etienne)]

Attachment: Patch proposal - vibration

I wasn't able to play anything while on a call (tried with ringer, telephony and publicnotification channels, with the proper permissions).

So the attached patch just makes sure that we are vibrating every 2 seconds as long as a call is waiting.
The previous behavior was to vibrate only once, which could be missed.

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 697490 [details] [diff] [review]
Patch proposal - vibration

Review of attachment 697490 [details] [diff] [review]:
-----------------------------------------------------------------

This makes sense. r=me!

We need to change the bug title I think.

Comment 12

[Joe Cheng [:jcheng] (please needinfo)]

can we dismiss the constant every 2 second vibration? 
there are cases when you are on an important call (such as an phone interview) and the 2nd call just wouldn't hang up. this will be very annoying and distracting

Comment 13

[Etienne Segonzac (:etienne)]

(In reply to Joe Cheng [:jcheng] from comment #12)
> can we dismiss the constant every 2 second vibration? 

Yes, just by taping the "ignore" button.

Comment 14

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/b67e7f5b2dbde0e291313167cb83239a5c4706f1

Comment 15

[Walter Chen[:ypwalter][:wachen]]

Device: Unagi
Build Identifier: 20130113070202
Update channel: 
   nightly b2g18 (pvt server)  
   unagi.zip	13-Jan-2013 08:06 	100M	 
   https://pvtbuilds.mozilla.org/pub/mozilla.org/b2g/nightly/mozilla-b2g18-unagi-eng/
Git commit info: 2013-11-13 15:15:51

Verified fixed

Comment 16

[Eric Chou [:ericchou] [:echou]]

Although now vibrate for every 2 secs, when using Bluetooth headset, it may be hard for users to notice there is an incoming call during a call. I just filed a bug about this, still hope that we could have notification sound. (bug 830666)