Closed Bug 826178 Opened 7 years ago Closed 7 years ago

Prefix all hexadecimal values with 0x in linker logs

Categories

(Core :: mozglue, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

The linker debugging logs show some hexadecimal values with a 0x prefix and some without, which is confusing.
Comment on attachment 697366 [details] [diff] [review]
Prefix all hexadecimal values with 0x in linker logs

Review of attachment 697366 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine; it might be a tiny bit better to use %#x, since that automagically adds the 0x for you.  But it doesn't add it when the value is zero (?!), so maybe being explicit really is better here.
Attachment #697366 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/35e73a67f08f
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.