826178 - Prefix all hexadecimal values with 0x in linker logs

Status: RESOLVED FIXED

(Core :: mozglue, defect)

Description

[Mike Hommey [:glandium]]

The linker debugging logs show some hexadecimal values with a 0x prefix and some without, which is confusing.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Prefix all hexadecimal values with 0x in linker logs

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 697366 [details] [diff] [review]
Prefix all hexadecimal values with 0x in linker logs

Review of attachment 697366 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine; it might be a tiny bit better to use %#x, since that automagically adds the 0x for you.  But it doesn't add it when the value is zero (?!), so maybe being explicit really is better here.

Comment 3

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/35e73a67f08f

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/35e73a67f08f