Closed Bug 826180 Opened 7 years ago Closed 7 years ago

No stylesheets shown after reloading a page with an iframe

Categories

(DevTools :: Style Editor, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 20

People

(Reporter: harth, Assigned: harth)

References

Details

Attachments

(1 file, 1 obsolete file)

STR:
1) visit http://google.com
2) Open Style Editor
3) Observe long list of stylesheets
4) Reload page

Expected:
Stylesheets re-appear in Style Editor after reload

Actual:
Empty Style Editor with "This page has no stylesheet" after reload


I have a fix.
Blocks: 816946
The style editor resets when it receives a "will-navigate" event. That event was being fired when any iframe in the page navigated.

This patch adds a check to make sure the navigate event is fired only when the root page navigates.
Assignee: nobody → fayearthur
Attachment #697372 - Flags: review?(jwalker)
Comment on attachment 697372 [details] [diff] [review]
Don't emit "navigate" event from target if child frame is navigating

Could you compare the windows instead of the URL?
Attachment #697372 - Flags: review?(jwalker)
This one is better, compares window objects instead of urls.
Attachment #697372 - Attachment is obsolete: true
Attachment #697380 - Flags: review?(jwalker)
Just realized that, thanks Paul
Attachment #697380 - Flags: review?(jwalker) → review+
Priority: -- → P1
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/12c4b39c61f0
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 20
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.