826180 - No stylesheets shown after reloading a page with an iframe

Status: RESOLVED FIXED

(DevTools :: Style Editor, defect, P1)

Description

[Heather Arthur [:harth]]

STR:
1) visit http://google.com
2) Open Style Editor
3) Observe long list of stylesheets
4) Reload page

Expected:
Stylesheets re-appear in Style Editor after reload

Actual:
Empty Style Editor with "This page has no stylesheet" after reload


I have a fix.

Comment 1

[Heather Arthur [:harth]]

Attachment: Don't emit "navigate" event from target if child frame is navigating

The style editor resets when it receives a "will-navigate" event. That event was being fired when any iframe in the page navigated.

This patch adds a check to make sure the navigate event is fired only when the root page navigates.

Comment 2

[Paul Rouget [:paul]]

Comment on attachment 697372 [details] [diff] [review]
Don't emit "navigate" event from target if child frame is navigating

Could you compare the windows instead of the URL?

Comment 3

[Heather Arthur [:harth]]

Attachment: Don't emit "navigate" event from target if child frame is navigating, take 2

This one is better, compares window objects instead of urls.

Comment 4

[Heather Arthur [:harth]]

Just realized that, thanks Paul

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/12c4b39c61f0

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/12c4b39c61f0