Closed
Bug 826183
Opened 12 years ago
Closed 12 years ago
DMD: in DMDReportAndDump, clear the reportedness state before running the reporters
Categories
(Core :: DMD, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file)
|
5.72 KB,
patch
|
justin.lebar+bug
:
review+
|
Details | Diff | Splinter Review |
DMDReportAndDump() should clear the reportedness state before it runs all the reporters. That way, if you've already run the reporters (e.g. by viewing about:memory) you won't get lots of spurious twice-counted warnings.
With that done, there shouldn't be any need for DMDDump().
|
Assignee | |
Comment 1•12 years ago
|
||
This patch exposes dmd::ClearReports() and calls it from the two places that
call dmd::Dump(). dmd::Dump() still also calls ClearReports() at the end,
which probably isn't necessary but doesn't hurt.
This change will allow
https://wiki.mozilla.org/Performance/MemShrink/DMD#Desktop_2 to be greatly
simplified, which is nice.
Attachment #697684 -
Flags: review?(justin.lebar+bug)
|
||
Updated•12 years ago
|
Attachment #697684 -
Flags: review?(justin.lebar+bug) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
|
|
Assignee | |
Updated•12 years ago
|
Component: General → DMD
You need to log in
before you can comment on or make changes to this bug.
Description
•