Closed Bug 826183 Opened 7 years ago Closed 7 years ago

DMD: in DMDReportAndDump, clear the reportedness state before running the reporters

Categories

(Core :: DMD, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(1 file)

DMDReportAndDump() should clear the reportedness state before it runs all the reporters.  That way, if you've already run the reporters (e.g. by viewing about:memory) you won't get lots of spurious twice-counted warnings.

With that done, there shouldn't be any need for DMDDump().
This patch exposes dmd::ClearReports() and calls it from the two places that
call dmd::Dump().  dmd::Dump() still also calls ClearReports() at the end,
which probably isn't necessary but doesn't hurt.

This change will allow
https://wiki.mozilla.org/Performance/MemShrink/DMD#Desktop_2 to be greatly
simplified, which is nice.
Attachment #697684 - Flags: review?(justin.lebar+bug)
Attachment #697684 - Flags: review?(justin.lebar+bug) → review+
https://hg.mozilla.org/mozilla-central/rev/bd3892e0345f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Component: General → DMD
You need to log in before you can comment on or make changes to this bug.