Closed Bug 826214 Opened 8 years ago Closed 8 years ago

New file with one line isn't shown

Categories

(bugzilla.mozilla.org :: Splinter, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: mounir, Assigned: glob)

References

Details

(Whiteboard: [ateamtrack: p=bugzilla q=2013q2 m=3])

Splinter view of the patch:
https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=824670&attachment=697164
Raw view of the patch:
https://bug824670.bugzilla.mozilla.org/attachment.cgi?id=697164&action=diff&collapsed=&context=patch&format=raw&headers=1

Steps to reproduce:
1. Open the splinter view.
2. Click on invalid_activity_href.webapp^headers^ or invalid_activity_href2.webapp^headers^.

Actual result:
The diff look empty for those files.

Expected result:
The following line should be in the 'add' state:
"Content-Type: application/x-web-app-manifest+json"
Whiteboard: [ateamtrack: p=bugzilla q=2 m=3]
Whiteboard: [ateamtrack: p=bugzilla q=2 m=3] → [ateamtrack: p=bugzilla q=2013q2 m=3]
Assignee: nobody → glob
the problem here is the hunk header doesn't provide the last value (it's optional, and is equal to 1 if not provided):

  @@ -0,0 +1 @@

so we need two regex's to match both forms.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified extensions/Splinter/web/splinter.js
Committed revision 8806.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Blocks: 885464
You need to log in before you can comment on or make changes to this bug.