Closed Bug 826214 Opened 9 years ago Closed 9 years ago
New file with one line isn't shown
Splinter view of the patch: https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=824670&attachment=697164 Raw view of the patch: https://bug824670.bugzilla.mozilla.org/attachment.cgi?id=697164&action=diff&collapsed=&context=patch&format=raw&headers=1 Steps to reproduce: 1. Open the splinter view. 2. Click on invalid_activity_href.webapp^headers^ or invalid_activity_href2.webapp^headers^. Actual result: The diff look empty for those files. Expected result: The following line should be in the 'add' state: "Content-Type: application/x-web-app-manifest+json"
Whiteboard: [ateamtrack: p=bugzilla q=2 m=3] → [ateamtrack: p=bugzilla q=2013q2 m=3]
the problem here is the hunk header doesn't provide the last value (it's optional, and is equal to 1 if not provided): @@ -0,0 +1 @@ so we need two regex's to match both forms. Committing to: bzr+ssh://email@example.com/bmo/4.2/ modified extensions/Splinter/web/splinter.js Committed revision 8806.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.