Closed
Bug 826231
Opened 12 years ago
Closed 12 years ago
Fix build warnings on MSVC in xpcom/tests
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: emk, Assigned: emk)
References
Details
Attachments
(1 file)
|
2.75 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Comment 2•12 years ago
|
||
Comment on attachment 697473 [details] [diff] [review]
patch
Review of attachment 697473 [details] [diff] [review]:
-----------------------------------------------------------------
::: xpcom/tests/TestSTLWrappers.cpp
@@ +12,5 @@
>
> // gcc errors out if we |try ... catch| with -fno-exceptions, but we
> // can still test on windows
> #ifdef _MSC_VER
> +# pragma warning( disable : 4530 )
Please add a warning saying which warning this is disabling.
Attachment #697473 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Pushed with adding the comment.
https://hg.mozilla.org/integration/mozilla-inbound/rev/880ec15a42bf
Flags: in-testsuite-
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•