82624 - printing of iframes print a large gray strip

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[dcone (gone)]

if you print a page containing an iframe, you will get a large gray stripe going 
down the page.  

<iframe src = "test.jpg">
</iframe>

Comment 1

[dcone (gone)]

Attachment: Patch

Comment 2

[dcone (gone)]

This patch changes the views back to a normal hieght after the reflow with the 
increased height.

Comment 3

[dcone (gone)]

Attachment: Newer simpler patch

Comment 4

[dcone (gone)]

this patch just makes sure we dont pass any transparent views to the display 
routine.

Comment 5

[Marc Attinasi]

Wow, that is simpler. 

So calling view->SetContentTransparency(PR_FALSE) somehow prevents the
transparent views from getting passed to the display routine? I don't understand
how that works... can you enlighten me?

Comment 6

[Marc Attinasi]

OK, Don just clued me in. I am fine with the change, but we really need a
comment in there saying something like:

// The views for the page should never be transparent but they are in some cases.
// Forcing the view to non-transparent until we can track down the root cause
//  - see bug XXXXX

where XXXXX is the bug number of a new bug :)

given that, sr=attinasi

Comment 7

[Kevin McCluskey (gone)]

Maybe we should add a style rule for the PageFrame to set its background color
to white? Lets file a new bug to investigate that. For a short term fix this is
fine though.

r=[e-mail]

Comment 8

[MichaelWright9]

I applied this patch to my MOZILLA_0_9_BRANCH build, and it did not fix the gray
strip problem. I am building on Linux and printing to a Postscript file. I am
using GTK. I have also tried this fix in my GTK embedded browser, and it does
not seem to be working. What platform are you testing this on?

Comment 9

[dcone (gone)]

I tested this on Windows nt 4.0 and Windows 2000.  This is cross platform code.. 
and should not matter what system your on.  What URL are you using to test this.
What about the simple test case in this bug.. does that fail here.  I also 
printed www.aol.com, which had the 4 iframes and 4 gray strips.. and that 
printed fine also.  I am at a lose here on whats going on.

Comment 10

[MichaelWright9]

Don- I checked out a clean version of the MOZILLA_0_9_BRANCH and applied the
patch. I built and tested aol.com and the simple test. Both produce gray strips
down the page. This build was on Linux using the following build config:
./configure --with-gtk=yes --disable-verbose-config-defs --disable-tests
--disable-mailnews --with-png=no --enable-cpp-rtti --enable-reproducible-build
make

Comment 11

[dcone (gone)]

Verified that the simple patch does not work on Linux.  I have not a clue why.
Micheal.. can you test the first patch.. see if that clears up your problem.  

Comment 12

[MichaelWright9]

Don- I tested the first patch, and I do get a different results. The result is
not correct but it is different. The gray stripe is no longer down the entire
page. Now the gray stripe is only beside the image, but in addition to that, the
image is drawn twice with different offsets. I will attach the Postscript files
that were created for each patch.

Comment 13

[MichaelWright9]

Attachment: Postscript results from testing patch 1 and patch 2.

Comment 14

[dcone (gone)]

Attachment: Patch part 1

Comment 15

[dcone (gone)]

Attachment: Patch part 2

Comment 16

[dcone (gone)]

2 part patch is attached.  Part 1 is a temporary patch, I created a bug to track 
the problem with the transparent large views that this fixes.  The bug number is 
in the patch for tracking.

Part 2 reduces the height of the page that is created, this is needed for Linux 
which has an overflow problem with very large regions, this corrects that 
problem and does not effect other pages when printing.

Comment 17

[rods (gone)]

100 was a completely arbitrary value, and 10 should work fine.

r=rods

Comment 18

[MichaelWright9]

Don- I applied the 2 patches and things look ok as long as you print with the 
paper size set to 8.5 X 11. If you choose LEGAL paper size, the gray strips are 
back.

Comment 19

[dcone (gone)]

Micheal can you try again, but with the line

const PRInt32 kHundredPagesHigh = 10;

changed to

const PRInt32 kHundredPagesHigh = 5; 

I think legal size may overflow the page hieght.. see if this works.

Comment 20

[MichaelWright9]

Don I changed "const PRInt32 kHundredPagesHigh = 5;" and that fixes the gray 
strips with legal paper size. Thanks!

Comment 21

[dcone (gone)]

Attachment: updated patch

Comment 22

[Marc Attinasi]

Provided this has been tested with all supported paper sizes, sr=attinasi

Comment 23

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 24

[rods (gone)]

I appears 5 is an ok value also r=rods

Comment 25

[dcone (gone)]

Fixed

Comment 26

[sujay]

verified in 6/21 build.