826302 - .valueAsDate should throw TypeError if passed something else than a Date

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Is this fixed now that bug 742206 landed?

Comment 2

[Mounir Lamouri (:mounir)]

Yes. Though I would like a test in content/html/content/test/forms/test_valueasdate_attribute.html before fixing the bug.

Comment 3

[Mounir Lamouri (:mounir)]

Attachment: Test

The basic idea was already tested, we only need to test the error name ;)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 745233 [details] [diff] [review]
Test

r=me

Do we need a followup bug on these bits:

354     // TODO: check the Date object value (UTCFullYear, UTCMonth and UTCDate)
355     // when .valueAsDate will stop returning null.

Comment 5

[Mounir Lamouri (:mounir)]

Attachment: Test

Let's do that here so we don't waste time with administrative overhead.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 747403 [details] [diff] [review]
Test

>+    is(element.valueAsDate.getUTCFullYear.toString(),
>+       Date.prototype.getUTCFullYear.toString(), "prototype is the same");

Why the toString bits for the methods?

>+    is(element.valueAsDate.toString(), witnessDate.toString(), "correct Date");

And here?

Comment 7

[Mounir Lamouri (:mounir)]

(In reply to Boris Zbarsky (:bz) from comment #6)
> Comment on attachment 747403 [details] [diff] [review]
> Test
> 
> >+    is(element.valueAsDate.getUTCFullYear.toString(),
> >+       Date.prototype.getUTCFullYear.toString(), "prototype is the same");
> 
> Why the toString bits for the methods?

This is indeed not needed.

> >+    is(element.valueAsDate.toString(), witnessDate.toString(), "correct Date");
> 
> And here?

.valueAsDate and witnessDate do not return the same object. .toString() is a simple way to check that those objects have the same value. I do not know if the objects are supposed to be seen equals when they have the same value even if they are not the same but it is possible that Mochitests have special path in is() for objects to check that they are the same instance.

Comment 8

[Mounir Lamouri (:mounir)]

Attachment: Test

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 747962 [details] [diff] [review]
Test

Oh, I see.  I'd prefer we use valueOf() there, not toString(), then.

r=me with that.

Comment 10

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/da886ed177a6

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/da886ed177a6