826425 - double-click on finished downloads in Library view doesn't open them

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect, P1)

Description

[Marco Bonardo [:mak]]

I downloaded 10 files, opened the Library view and double click them to open, nothing happens, no interesting errors reported to the console.

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 698011 [details] [diff] [review]
patch

Review of attachment 698011 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/downloads/content/allDownloadsViewOverlay.js
@@ +1119,5 @@
>        }
>      }
> +  },
> +
> +  onDoubleClick: function DPV_onDoubleClick() {

please, handle only left mouse button

Comment 3

[Asaf Romano (gone)]

Attachment: as checked in

http://hg.mozilla.org/integration/mozilla-inbound/rev/8f9693d92791

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8f9693d92791

Comment 5

[Jim Jeffery not reading bug-mail 1/2/11]

Is it expected that 'old' downloads in the Library will NOT open with double-click as fixed by this patch?

New downloads seems to open OK, older ones do not.

Tested using latest hourly m-c build cset:
https://hg.mozilla.org/mozilla-central/rev/20d1a5916ef6
Win7 X64bit

Comment 6

[Jim Jeffery not reading bug-mail 1/2/11]

The 'double-click' to open seems to be intermittant.  I just downloaded another build file from a day or so ago (regression testing) and double-clicking did NOT open as expected and as I stated above about only working with 'New Downloaded Files'.

I also see these errors in Error Console2:

this appears on first open of the Show all Downloads:
Error: TypeError: view.selectNode is not a function
Source file: chrome://browser/content/places/places.js
Line: 64


This error appears when double-clicking a file:
Error: TypeError: this.dataItem is undefined
Source file: resource://gre/modules/DownloadsCommon.jsm
Line: 431


I will be out most of day, so can't file a new bug if needed.  Not sure if this one should be re-opened.

Comment 7

[Mihai Morar, (:MihaiMorar)]

I confirm the fix is verified on FF19b1 and Latest Nightly (2013-02-21) on Windows 7, I could reproduce the issue on Nightly(2013-01-03) but on FF 20.b1 and Latest Nightly it works as expected.

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0(20130220104816)

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130109 Firefox/21.0(20130109030942)

Comment 8

[Mihai Morar, (:MihaiMorar)]

(In reply to MarioMi (:MarioMi) from comment #7)

Verified Fixed on FF 20.b1 not FF19.b1. My bad!