Closed
Bug 826439
Opened 13 years ago
Closed 13 years ago
histogram stats for non-linear histograms should use floats for log calculations
Categories
(Toolkit :: Telemetry, defect)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
1.12 KB,
patch
|
vladan
:
review+
|
Details | Diff | Splinter Review |
We don't need the extra precision of doubles and the float versions are significantly faster.
|
Assignee | |
Comment 1•13 years ago
|
||
As suggested elsewhere.
Attachment #697631 -
Flags: review?(vdjeric)
|
||
Updated•13 years ago
|
Attachment #697631 -
Flags: review?(vdjeric) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
|
|
||
Comment 3•13 years ago
|
||
Backed out for xpcshell failures:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=6e391f971a13
https://hg.mozilla.org/integration/mozilla-inbound/rev/2da7fcc87f83
|
|
Assignee | |
Comment 4•13 years ago
|
||
Relanded with simple fix to avoid float precision problems. xpcshell tests green locally (linux64) and on try: https://tbpl.mozilla.org/?tree=Try&rev=a3a77008889c (the b-c failures are unrelated to this change).
https://hg.mozilla.org/integration/mozilla-inbound/rev/c43c4835dafd
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
|
|
||
Updated•13 years ago
|
Assignee: nobody → nfroyd
You need to log in
before you can comment on or make changes to this bug.
Description
•