82647 - IRIX/gcc build core dumps in nsinstall

Status: RESOLVED FIXED

(NSS :: Build, defect, P1)

Description

[John Mark Vandenberg]

gcc -mips3 on IRIX causes functions in <string.h> to core dump.  I have raised 
a bug in BugWorks on regarding this.

Gcc builds mips3 by default anyhow, and removing the -mips3 resolves this 
problem.

% cat hello.c 
#include <stdio.h>
#include <string.h>

int main(int argc, char ** argv) {
  char *program;
  printf("using strcmp...\n");
  strcmp(argv[0], "he");
  printf("using strchr...\n");
  program = strchr(argv[0], '/');
  printf("using strrchr...\n");
  program = strrchr(argv[0], '/');
}
% gmake
gcc -E -o hello.i hello.c
gcc -o hello1 hello.i
gcc -o hello2 -mips3 hello.i
In file included from hello.c:2:
/usr/include/string.h:67: warning: conflicting types for built-in function 
`memcpy'
/usr/include/string.h:74: warning: conflicting types for built-in function 
`memcmp'
/usr/include/string.h:95: warning: conflicting types for built-in function 
`memset'
/usr/include/string.h:97: warning: conflicting types for built-in function 
`strlen'

( these warnings can be removed by -fno-builtins , and are un-related )

% ./hello1
using strcmp...
using strchr...
using strrchr...
% ./hello2
using strcmp...
Bus error (core dumped)

Comment 1

[John Mark Vandenberg]

Attachment: Patch to IRIX6.5.mk to remove -mips3 from gcc build

Comment 2

[Wan-Teh Chang]

Funny that I just fixed this bug on the trunk of NSS
and was thinking about asking you why -mips3 doesn't
work (the -mips3 option is documented in the GNU CC
manual).

The Mozilla source tree is now closed for the 0.9.1
release.  So this fix may have to wait until the tree
re-opens.  I don't know how to get approval for an
exception.  Maybe send email to [e-mail]?

In any case, you can always apply this patch to your
tree...

Comment 3

[John Mark Vandenberg]

Given that this is only in the NSS build (ie not autoconf), it is not really 
important if this one gets in for 0.9.1 or not.

Comment 4

[John Mark Vandenberg]

After apply the patch to this bug, I have tested both gcc and gcc optimise 
builds and they pass all tests.  The MIPSpro build fails several tests, however 
the MIPSpro optimise build passes all tests.

Comment 5

[John Mark Vandenberg]

Has this been pushed in?

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

a=dbaron for trunk checkin (on behalf of drivers)

Comment 7

[Wan-Teh Chang]

I checked in the patch on the NSS_3_2_BRANCH and moved
the NSS_CLIENT_TAG to include it.  This fix is already
on the trunk of NSS.

Comment 8

[Wan-Teh Chang]

The fix is not in 3.2.2 but is in 3.3 and the 3.2 branch.
Since we are not planning to make any new 3.2.x releases,
I am setting the target milestone to 3.3.