826479 - Assertion failure: mInitialized trying to Ctrl+Middle-click paste

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[[e-mail]]

Steps to reproduce problem:
1. If necessary, enable middlemouse.paste
2. Make a selection
3. Hold down Ctrl and middle-click a textarea

Comment 1

[[e-mail]]

Attachment: Proposed patch

> [no attachments can be made obsolete]

(Just testing!)

Comment 2

[(no longer active)]

Comment on attachment 697720 [details] [diff] [review]
Proposed patch

Review of attachment 697720 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/text/nsPlaintextEditor.cpp
@@ +1355,5 @@
>  #ifdef DEBUG_clipboard
>      printf("Got flavor [%s]\n", flav);
>  #endif
> +    if (0 == nsCRT::strcmp(flav, kUnicodeMime) ||
> +        0 == nsCRT::strcmp(flav, kMozTextInternal))

Why is this hunk necessary?

Comment 3

[[e-mail]]

(In reply to Ehsan Akhgari from comment #2)
> (From update of attachment 697720 [details] [diff] [review])
> > +    if (0 == nsCRT::strcmp(flav, kUnicodeMime) ||
> > +        0 == nsCRT::strcmp(flav, kMozTextInternal))
> Why is this hunk necessary?
Rather than reinvent the wheel I copied nsPlaintextEditor::Paste (which for some reason lives in nsPlaintextDataTransfer.cpp) which uses PrepareTransferable which assumes the caller is interested in both flavours.

Comment 4

[[e-mail]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/ac810061a175

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ac810061a175