82648 - Performance: Attempt to find a menu short-cut when press <alt>+<up arrow> and other non-char keys

Status: NEW

(Core :: XUL, defect)

Description

[Roy Yokoyama]

We should not iterate thru the MenuBar ShortCut for non-char keys.

Here is the steps:
1) run debugger
2) open browser
3) set breakpoint on line 197 nsMenuBarListner.cpp
4) press <alt>+<up arrow>
5) stops at the break point, 
6) check for theChar value.  It's NULL.
7) we go and iterate a short cut to find a match.  <=== not necessary.

---------- //layout/xul/base/src/nsMenuBarListener.cpp [approx. line 197]----
keyEvent->GetCharCode(&theChar);
PRBool active = PR_FALSE;
mMenuBarFrame->ShortcutNavigation(theChar, active);
.....
-------------------------------------------------------------------------

Comment 1

[joki (gone)]

This is event system usage by menus, not the event system itself

Comment 2

[Mike Pinkerton (not reading bugmail)]

ok

Comment 3

[:deanis74]

Should be as simple as...

keyEvent->GetCharCode(&theChar);
if (theChar) {
  PRBool active = PR_FALSE;
  mMenuBarFrame->ShortcutNavigation(theChar, active);
  .....
}

Comment 4

[:deanis74]

i'll take this, if it's still relevant

Comment 5

[:deanis74]

Back to default owner.  Suggested fix is in comment 3.