The default bug view has changed. See this FAQ.

CSS validation errors in toolbox.css

VERIFIED FIXED in Firefox 20

Status

()

Firefox
Developer Tools: Framework
--
trivial
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: Sergiu Dumitriu, Assigned: Sergiu Dumitriu)

Tracking

20 Branch
Firefox 20
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox20+ verified)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:20.0) Gecko/20130101 Firefox/20.0
Build ID: 20130103013203

Steps to reproduce:

Using Nightly (v20) on Linux or Windows, open the Error console, then toggle the developer tools.


Actual results:

In the Error console there's a warning:

    Warning: Expected ':' but found 'size'.  Declaration dropped.
    Source File: chrome://browser/skin/devtools/toolbox.css
    Line: 176

This is caused by the commit for bug 818033, at https://hg.mozilla.org/mozilla-central/diff/4cd6a880978c/browser/themes/gnomestripe/devtools/toolbox.css#l1.163 and https://hg.mozilla.org/mozilla-central/diff/4cd6a880978c/browser/themes/winstripe/devtools/toolbox.css#l1.164

Apart from that, there are other issue that are not reported by Firefox, but which are considered errors by the W3C CSS validation: url() values without quotes around the URL, and a non-standard syntax for radial gradients.
(Assignee)

Comment 1

4 years ago
Created attachment 697751 [details] [diff] [review]
Proposed patch
(Assignee)

Updated

4 years ago
Severity: normal → trivial
Component: Untriaged → Developer Tools
(Assignee)

Updated

4 years ago
Blocks: 816946

Comment 2

4 years ago
Confirmed 
http://hg.mozilla.org/mozilla-central/rev/6955309291ee
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20130103 Firefox/20.0 ID:20130103030946

Warning: Expected ':' but found 'size'.  Declaration dropped.
Source file: chrome://browser/skin/devtools/toolbox.css
Line: 177
Status: UNCONFIRMED → NEW
Ever confirmed: true

Updated

4 years ago
Blocks: 818033
tracking-firefox20: --- → ?
OS: Linux → All
Thank you for your patch Sergiu!

When the patch is ready for review, please ask someone for a review.

Details at:
https://developer.mozilla.org/en-US/docs/Developer_Guide/How_to_Submit_a_Patch
Assignee: nobody → sergiu
Status: NEW → ASSIGNED
Component: Developer Tools → Developer Tools: Framework
Hardware: x86_64 → All

Comment 4

4 years ago
Comment on attachment 697751 [details] [diff] [review]
Proposed patch

Thank you!
Attachment #697751 - Flags: review+

Comment 5

4 years ago
Created attachment 697888 [details] [diff] [review]
reformated

Patch from Sergiu, with author name + bug summary + 8 lines of context.

Sergiu, thank you for fixing this. For your next patches, please look at this: https://developer.mozilla.org/en-US/docs/Creating_a_patch
Attachment #697888 - Flags: review+

Updated

4 years ago
Whiteboard: [land-in-fx-team]
(Assignee)

Comment 6

4 years ago
Thanks for the tips, Paul.
https://hg.mozilla.org/integration/fx-team/rev/34eac9bec3af
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]

Updated

4 years ago
status-firefox20: --- → affected
tracking-firefox20: ? → +
https://hg.mozilla.org/mozilla-central/rev/34eac9bec3af
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox20: affected → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 20
I confirm the fix is verified on FF 20b6 on Windows 7 x64 and Ubuntu 12.04:

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0(20130320062118)
Mozilla/5.0 (X11; Linux i68; rv:20.0) Gecko/20100101 Firefox/20.0(20130320062118)
Status: RESOLVED → VERIFIED
status-firefox20: fixed → verified
You need to log in before you can comment on or make changes to this bug.