826563 - CSS validation errors in toolbox.css

Status: VERIFIED FIXED

(DevTools :: Framework, defect)

Description

[Sergiu Dumitriu]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:20.0) Gecko/20130101 Firefox/20.0
Build ID: 20130103013203

Steps to reproduce:

Using Nightly (v20) on Linux or Windows, open the Error console, then toggle the developer tools.


Actual results:

In the Error console there's a warning:

    Warning: Expected ':' but found 'size'.  Declaration dropped.
    Source File: chrome://browser/skin/devtools/toolbox.css
    Line: 176

This is caused by the commit for bug 818033, at https://hg.mozilla.org/mozilla-central/diff/4cd6a880978c/browser/themes/gnomestripe/devtools/toolbox.css#l1.163 and https://hg.mozilla.org/mozilla-central/diff/4cd6a880978c/browser/themes/winstripe/devtools/toolbox.css#l1.164

Apart from that, there are other issue that are not reported by Firefox, but which are considered errors by the W3C CSS validation: url() values without quotes around the URL, and a non-standard syntax for radial gradients.

Comment 1

[Sergiu Dumitriu]

Attachment: Proposed patch

Comment 2

[Alice0775 White]

Confirmed 
http://hg.mozilla.org/mozilla-central/rev/6955309291ee
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20130103 Firefox/20.0 ID:20130103030946

Warning: Expected ':' but found 'size'.  Declaration dropped.
Source file: chrome://browser/skin/devtools/toolbox.css
Line: 177

Comment 3

[Mihai Sucan [:msucan]]

Thank you for your patch Sergiu!

When the patch is ready for review, please ask someone for a review.

Details at:
https://developer.mozilla.org/en-US/docs/Developer_Guide/How_to_Submit_a_Patch

Comment 4

[Paul Rouget [:paul]]

Comment on attachment 697751 [details] [diff] [review]
Proposed patch

Thank you!

Comment 5

[Paul Rouget [:paul]]

Attachment: reformated

Patch from Sergiu, with author name + bug summary + 8 lines of context.

Sergiu, thank you for fixing this. For your next patches, please look at this: https://developer.mozilla.org/en-US/docs/Creating_a_patch

Comment 6

[Sergiu Dumitriu]

Thanks for the tips, Paul.

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/34eac9bec3af

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/34eac9bec3af

Comment 9

[Mihai Morar, (:MihaiMorar)]

I confirm the fix is verified on FF 20b6 on Windows 7 x64 and Ubuntu 12.04:

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0(20130320062118)
Mozilla/5.0 (X11; Linux i68; rv:20.0) Gecko/20100101 Firefox/20.0(20130320062118)