826565 - Updates on elm are currently failing

Status: RESOLVED DUPLICATE of bug 793767

(Firefox for Metro Graveyard :: General, defect)

Description

[Jim Mathies [:jimm]]

Tried doing an update from the about option but wasn't able to. This was with metrofx running and shutdown.

bbondy, any suggestions on logs and such to look at to diagnose?

Comment 1

[Brian R. Bondy [:bbondy]]

Probably related to recent packager changes done which reverted some of the previous updater work on elm.  I'll take a look thanks for bringing it up.  I'll let you know if I need logs.

Comment 2

[Brian R. Bondy [:bbondy]]

This changeset hosed updates on elm. 
Unfortunately there is no tracking bug associated with the commit.
https://hg.mozilla.org/projects/elm/rev/d340f9e6ade9

Basically it thinks the installation directory is <installdir>\browser and so it can't find update-settings.ini and therefore the channel check on the MAR file fails. 

CC'ing glandium for recommended fix since I previously already fixed this once before it was reverted.

Comment 3

[Brian R. Bondy [:bbondy]]

Users who updated to any recent builds on elm will need to reinstall to get updates by the way.

Comment 4

[Mike Hommey [:glandium]]

(In reply to Brian R. Bondy [:bbondy] from comment #2)
> This changeset hosed updates on elm. 
> Unfortunately there is no tracking bug associated with the commit.
> https://hg.mozilla.org/projects/elm/rev/d340f9e6ade9

That changeset is an intermediate step. https://hg.mozilla.org/projects/elm/rev/336034681e01 introduces a replacement.

Comment 5

[Brian R. Bondy [:bbondy]]

The value of installDir at this location (passed via toolkit/xre via command line parameters) is <installationdir>/browser

http://dxr.mozilla.org/mozilla-central/toolkit/mozapps/update/updater/updater.cpp.html?string=UpdateThreadFunc#l2086

Can you take a look?

Comment 6

[Mike Hommey [:glandium]]

Attachment: Tentative patch

Can you try this?

(This would need to be merged with bug 793767)

Comment 7

[Brian R. Bondy [:bbondy]]

Comment on attachment 697971 [details] [diff] [review]
Tentative patch

Review of attachment 697971 [details] [diff] [review]:
-----------------------------------------------------------------

Pretty sure this is correct but having trouble testing it at the moment. Let's just push to elm since it can't do any harm to the current update situation. I'll verify there and let you know if there is a problem.

::: toolkit/xre/nsUpdateDriver.cpp
@@ +994,5 @@
>        updRoot = dirProvider->GetAppDir();
>  
>      greDir = dirProvider->GetGREDir();
> +    nsCOMPtr<nsIFile> exeFile;
> +    rv = mDirProvider.GetFile(XRE_EXECUTABLE_FILE, &persistent,

- mDirProvider.  ...
+ dirProvider->  ...

Comment 8

[Jim Mathies [:jimm]]

https://hg.mozilla.org/projects/elm/rev/aebb07d72cbc

Comment 9

[Jim Mathies [:jimm]]

backed out due to build bustage on osx.

https://hg.mozilla.org/projects/elm/rev/7c83383dc808

Comment 10

[Brian R. Bondy [:bbondy]]

Comment 7 :)

Comment 11

[Jim Mathies [:jimm]]

(In reply to Brian R. Bondy [:bbondy] from comment #10)
> Comment 7 :)

Well that's easy to fix. :) Do you think that's the only issue?

Comment 12

[Brian R. Bondy [:bbondy]]

Yes the patch wouldn't compile on windows either because of that, after that fix it compiled fine. I didn't get to test an update but it's easier to test on elm.

Comment 13

[Jim Mathies [:jimm]]

https://hg.mozilla.org/projects/elm/rev/cd2b11cb6527

Comment 14

[Brian R. Bondy [:bbondy]]

Summary of the remaining problem can be found here: 829415

Basically there were 2 problems, and glandium's fix did fix the first.
The second problem is related to how things are being signed at build time. I think it got messed up when we added in the other platforms.  Both MARs and exes are being signed wrong, which are signed in independent ways.