826580 - Capture application version history

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[Gregory Szorc [:gps]]

We need a probe that records history of application version changes. Essentially we need a new entry in a daily field containing the version.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Capture application versions, v1

It definitely needs more test coverage.

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 697765 [details] [diff] [review]
Capture application versions, v1

Review of attachment 697765 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/healthreport/providers.jsm
@@ +146,5 @@
> +    let currentVersion = ai.version;
> +    let lastVersion = yield this.getState("lastVersion");
> +
> +    if (currentVersion == lastVersion) {
> +      return;

OK, so we don't record a daily measurement if the version is the same. We also don't record one if we fail to fetch Services.appinfo. Can we please distinguish these two states?

It seems like setting a sentinel value in the failure case would be the simplest approach….

::: services/healthreport/tests/xpcshell/test_provider_appinfo.js
@@ +61,5 @@
> +  do_check_true(day.has("version"));
> +  let value = day.get("version");
> +  do_check_true(Array.isArray(value));
> +  do_check_eq(value.length, 1);
> +

Check that the version is the same one you retrieve from Services.appinfo.

Comment 3

[Gregory Szorc [:gps]]

Attachment: Capture application versions, v2

Comment 4

[Richard Newman [:rnewman]]

Comment on attachment 698351 [details] [diff] [review]
Capture application versions, v2

Review of attachment 698351 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/healthreport/providers.jsm
@@ +124,5 @@
> +    return Task.spawn(this._onInit.bind(this));
> +  },
> +
> +  _onInit: function () {
> +    // Serviecs.appInfo should always be defined for any reasonably behaving

s/Serviecs/Services

Comment 5

[Gregory Szorc [:gps]]

https://hg.mozilla.org/services/services-central/rev/d4ce01fb6255

Comment 6

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/d4ce01fb6255