826602 - Rename nsHTMLCanvasElement to mozilla::dom::HTMLCanvasElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

I'm doing this separately to avoid bit-rot while I'm working on moving HTMLCanvasElement to Web IDL.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 697792 [details] [diff] [review]
Patch (v1)

>+DOMCI_DATA(MozCanvasPrintState, HTMLCanvasPrintState)

This probably doesn't work, I would expect.  Normally DOMCI_DATA needs to be outside namespaces.

>NS_NewHTMLCanvasElement(already_AddRefed<nsINodeInfo> aNodeInfo,

And this needs to be outside namespaces too, no?

>+DOMCI_NODE_DATA(HTMLCanvasElement, HTMLCanvasElement)

Likewise.

r=me with those fixed

Comment 3

[(no longer active)]

(In reply to Boris Zbarsky (:bz) from comment #2)
> Comment on attachment 697792 [details] [diff] [review]
> Patch (v1)
> 
> >+DOMCI_DATA(MozCanvasPrintState, HTMLCanvasPrintState)
> 
> This probably doesn't work, I would expect.  Normally DOMCI_DATA needs to be
> outside namespaces.
> 
> >NS_NewHTMLCanvasElement(already_AddRefed<nsINodeInfo> aNodeInfo,
> 
> And this needs to be outside namespaces too, no?
> 
> >+DOMCI_NODE_DATA(HTMLCanvasElement, HTMLCanvasElement)
> 
> Likewise.

Sorry, submitted the patch too soon, before the linker did a review very similar to yours.  :-)

Comment 4

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bfb788e7ef51

Comment 5

[(no longer active)]

Sigh... backed out because of build failures: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=bfb788e7ef51

https://hg.mozilla.org/integration/mozilla-inbound/rev/e2441f515b0d

Comment 6

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a6ddfcf593bd

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a6ddfcf593bd