Closed Bug 826602 Opened 7 years ago Closed 7 years ago

Rename nsHTMLCanvasElement to mozilla::dom::HTMLCanvasElement

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

I'm doing this separately to avoid bit-rot while I'm working on moving HTMLCanvasElement to Web IDL.
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #697792 - Flags: review?(bzbarsky)
Comment on attachment 697792 [details] [diff] [review]
Patch (v1)

>+DOMCI_DATA(MozCanvasPrintState, HTMLCanvasPrintState)

This probably doesn't work, I would expect.  Normally DOMCI_DATA needs to be outside namespaces.

>NS_NewHTMLCanvasElement(already_AddRefed<nsINodeInfo> aNodeInfo,

And this needs to be outside namespaces too, no?

>+DOMCI_NODE_DATA(HTMLCanvasElement, HTMLCanvasElement)

Likewise.

r=me with those fixed
Attachment #697792 - Flags: review?(bzbarsky) → review+
(In reply to Boris Zbarsky (:bz) from comment #2)
> Comment on attachment 697792 [details] [diff] [review]
> Patch (v1)
> 
> >+DOMCI_DATA(MozCanvasPrintState, HTMLCanvasPrintState)
> 
> This probably doesn't work, I would expect.  Normally DOMCI_DATA needs to be
> outside namespaces.
> 
> >NS_NewHTMLCanvasElement(already_AddRefed<nsINodeInfo> aNodeInfo,
> 
> And this needs to be outside namespaces too, no?
> 
> >+DOMCI_NODE_DATA(HTMLCanvasElement, HTMLCanvasElement)
> 
> Likewise.

Sorry, submitted the patch too soon, before the linker did a review very similar to yours.  :-)
Blocks: 826740
https://hg.mozilla.org/mozilla-central/rev/a6ddfcf593bd
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.