B2G RIL: getOPL causes parcel error when reading unused octets.

RESOLVED FIXED in mozilla20

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: allstars.chh, Assigned: allstars.chh)

Tracking

unspecified
mozilla20
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Got the following log

I/Gecko   (  109): RIL Worker: New incoming parcel of size 60
I/Gecko   (  109): RIL Worker: Parcel (size 60): 0,0,0,0,51,0,0,0,0,0,0,0,144,0,0,0,0,0,0,0,16,0,0,0,102,0,102,0,102,0,102,0,102,0,102,0,102,0,102,0,102,0,102,0,102,0,102,0,102,0,102,0,102,0,102,0,0,0,0,0
I/Gecko   (  109): RIL Worker: We have at least one complete parcel.
I/Gecko   (  109): RIL Worker: Solicited response for request type 28, token 51, error 0
I/Gecko   (  109): RIL Worker: Handling parcel as REQUEST_SIM_IO
I/Gecko   (  109): RIL Worker: Something's wrong, found string delimiter: 102
I/Gecko   (  109): RIL Worker: New outgoing parcel of type 28
I/Gecko   (  109): RIL Worker: Outgoing parcel: 0,0,0,132,28,0,0,0,52,0,0,0,178,0,0,0,198,111,0,0,8,0,0,0,51,0,102,0,48,0,48,0,55,0,102,0,102,0,102,0,0,0,0,0,12,0,0,0,4,0,0,0,8,0,0,0,255,255,255,255,255,255,255,255,32,0,0,0,97,0,48,0,48,0,48,0,48,0,48,0,48,0,48,0,56,0,55,0,49,0,48,0,48,0,50,0,102,0,102,0,102,0,102,0,102,0,102,0,102,0,102,0,56,0,57,0,48,0,54,0,49,0,57,0,48,0,48,0,48,0,48,0,0,0,0,0
I/Gecko   (  109): RIL Worker: Parcel handler didn't consume whole parcel, 20 bytes left over
I/Gecko   (  109): RIL Worker: Next parcel size unknown, going to sleep.


If some record in OPL is empty, it would be all 0xff,
and in getOPL, it doesn't handle the remaining unused octets if the record is empty.
Summary: B2G RIL: getOPL causes parcel error when reading unused records. → B2G RIL: getOPL causes parcel error when reading unused octets.
Posted patch PatchSplinter Review
Assignee: nobody → allstars.chh
Status: NEW → ASSIGNED
Attachment #697795 - Flags: review?(htsai)
Comment on attachment 697795 [details] [diff] [review]
Patch

Review of attachment 697795 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, thanks.
Attachment #697795 - Flags: review?(htsai) → review+
https://hg.mozilla.org/mozilla-central/rev/99e4076687ca
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.