Closed Bug 826619 Opened 7 years ago Closed 4 years ago
Added to the spec in <http://html5.org/tools/web-apps-tracker?from=7634&to=7635>; need to check if our implementation matches that.
The fillRule property has been superseded by CanvasWindingRule and no longer defined in the latest spec. We should just remove mozFillRule.
Here's a patch which removes mozFillRule, assuming that's still what's desirable. A try run seems fine: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e4f85e4c5fc
Attachment #8778079 - Flags: review?(bas)
Attachment #8778079 - Flags: review?(bas) → review+
:emk, should I go ahead and mark this as checkin-needed, or has the situation changed since you wrote comment 1?
Assignee: nobody → wisniewskit
Status: NEW → ASSIGNED
No changes except that CanvasWindingRule has been renamed to CanvasFillRule. But a DOM peer should sign-off the WebIDL change.
:mrbkap, mind signing off on the WebIDL change?
Attachment #8778079 - Flags: review+
r=me on the WebIDL change.
Thanks! Requesting check-in.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/0ca0282fe48b Remove Canvas mozFillRule. r=mrbkap r=bas
Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/canvasrenderingcontext2d-mozfillrule-has-been-removed/
mozFillRule removed from https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D and https://developer.mozilla.org/en-US/Firefox/Releases/51#Canvas mentions it.
You need to log in before you can comment on or make changes to this bug.