Closed
Bug 826619
Opened 12 years ago
Closed 9 years ago
Remove mozFillRule
Categories
(Core :: Graphics: Canvas2D, defect)
Core
Graphics: Canvas2D
Tracking
()
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: Ms2ger, Assigned: wisniewskit)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(1 file)
5.77 KB,
patch
|
bas.schouten
:
review+
mrbkap
:
review+
|
Details | Diff | Splinter Review |
Added to the spec in <http://html5.org/tools/web-apps-tracker?from=7634&to=7635>; need to check if our implementation matches that.
Comment 1•12 years ago
|
||
The fillRule property has been superseded by CanvasWindingRule and no longer defined in the latest spec. We should just remove mozFillRule.
Assignee | ||
Comment 2•9 years ago
|
||
Here's a patch which removes mozFillRule, assuming that's still what's desirable. A try run seems fine: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e4f85e4c5fc
Attachment #8778079 -
Flags: review?(bas)
Updated•9 years ago
|
Keywords: dev-doc-needed
Updated•9 years ago
|
Attachment #8778079 -
Flags: review?(bas) → review+
Assignee | ||
Comment 3•9 years ago
|
||
:emk, should I go ahead and mark this as checkin-needed, or has the situation changed since you wrote comment 1?
Assignee: nobody → wisniewskit
Status: NEW → ASSIGNED
Flags: needinfo?(VYV03354)
Comment 4•9 years ago
|
||
No changes except that CanvasWindingRule has been renamed to CanvasFillRule. But a DOM peer should sign-off the WebIDL change.
Flags: needinfo?(VYV03354)
Assignee | ||
Comment 5•9 years ago
|
||
:mrbkap, mind signing off on the WebIDL change?
Flags: needinfo?(mrbkap)
Updated•9 years ago
|
Attachment #8778079 -
Flags: review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ca0282fe48b
Remove Canvas mozFillRule. r=mrbkap r=bas
Keywords: checkin-needed
Comment 9•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Comment 10•9 years ago
|
||
Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/canvasrenderingcontext2d-mozfillrule-has-been-removed/
Keywords: site-compat
Updated•8 years ago
|
Summary: Unprefix mozFillRule → Remove mozFillRule
Comment 11•8 years ago
|
||
mozFillRule removed from https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D
and
https://developer.mozilla.org/en-US/Firefox/Releases/51#Canvas mentions it.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•