82663 - Can't close source window with shortcut key

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Koike Kazuhiko]

Can't close HTML source window with shortcut key(Ctrl+W).

You can close message source window with shortcut key
if you click the window before.

Comment 1

[sairuh (rarely reading bugmail)]

regression. all platforms, at least as of the 2001.05.23 bits. hrm.

what caused this, and could it be easily fixed? i cannot using accel+W even
after clicking in the source window. fwiw, i can close browser windows just fine
with accel+W.

Comment 2

[sairuh (rarely reading bugmail)]

get the following console output from my debug [20:03 from last night]:

JavaScript error: 
 line 0: BrowserCanClose is not defined

Comment 3

[Doron Rosenberg (IBM)]

hmm. Lemme clean my viewsource UI stuff and look at this.

Comment 4

[Doron Rosenberg (IBM)]

ok, i have a cheap patch. Include function BrowserCanClose() from navigator.js
in viewsource.js. I wish we would spit js errors on xul, luckily se has a debug
build.

Should I create a temp patch? Or does anyone have another idea?

Comment 5

[Blake Ross]

-> doron

Comment 6

[Doron Rosenberg (IBM)]

blake: would this way of patching it be fine (ie a sr=). This will be really
fixed with my viewsource UI stuff.  

Comment 7

[Doron Rosenberg (IBM)]

Attachment: patch

Comment 8

[Doron Rosenberg (IBM)]

patch attached, copies the function. This will be fixed when the viewsource UI
lands, since that includes navigator.js (where the function is located).

I also added a line of code to make sure that the content gets focus for
viewsource (so ctrl-w will work without clicking on the source window).

making 0.9.1, comments or r/sr?

Comment 9

[Doron Rosenberg (IBM)]

Also i could just have a return true; in that function and nothing else. Blake,
comments?

Comment 10

[Blake Ross]

I say we just wait for your big patch to land...don't see why this is critical 
for 0.9.1.

Comment 11

[Doron Rosenberg (IBM)]

ok

Comment 12

[doctor__j]

*** Bug 84819 has been marked as a duplicate of this bug. ***

Comment 13

[Doron Rosenberg (IBM)]

since 63026 will go into 0.9.2, and fix this, making it dependant

Comment 14

[Doron Rosenberg (IBM)]

should be fixed in new builds

Comment 15

[Chris Lyon]

WFM on build 2001061708 on Win2K.

Comment 16

[Doron Rosenberg (IBM)]

fixed it is

Comment 17

[sairuh (rarely reading bugmail)]

yay! vrfy fixed using 2001.06.18.08 comm bits on linux, winnt and mac.