TBPL's "Loading failed: <foo>" messages should state what action failed

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

({sheriffing-P1})

Trunk
sheriffing-P1

Details

Attachments

(1 attachment)

Periodically, upon loading TBPL we get various "Loading failed: {parsererror,...}" type failures due to infra issues.

These come from the |loadTracker.loadFailed(thisStatusResult)| calls when loading the treestatus message, the pushlog json, the hidden builders list or the pending/running builds json.

We should include the action in the failure message shown, to simplify working out what resource is corrupt/inaccessible/...
Created attachment 697911 [details] [diff] [review]
Patch v1

Adds URLs to callers of loadFailed that are ajax requests. Note some uses are not, otherwise I would have factored more of this into LoadTracker.js
Attachment #697911 - Flags: review?(jhammel)

Comment 2

6 years ago
Comment on attachment 697911 [details] [diff] [review]
Patch v1

Makes me wonder if we call loadTracker.loadFailed without a url, but I'm not going to look through the code.  Nice :)
Attachment #697911 - Flags: review?(jhammel) → review+
Not all of them do.

Thank you for the quick review :-)

https://hg.mozilla.org/webtools/tbpl/rev/d4ad9eb7fece
In production :-)
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.