826671 - TBPL's "Loading failed: <foo>" messages should state what action failed

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

Periodically, upon loading TBPL we get various "Loading failed: {parsererror,...}" type failures due to infra issues.

These come from the |loadTracker.loadFailed(thisStatusResult)| calls when loading the treestatus message, the pushlog json, the hidden builders list or the pending/running builds json.

We should include the action in the failure message shown, to simplify working out what resource is corrupt/inaccessible/...

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

Adds URLs to callers of loadFailed that are ajax requests. Note some uses are not, otherwise I would have factored more of this into LoadTracker.js

Comment 2

[Jeff Hammel]

Comment on attachment 697911 [details] [diff] [review]
Patch v1

Makes me wonder if we call loadTracker.loadFailed without a url, but I'm not going to look through the code.  Nice :)

Comment 3

[Ed Morley [:emorley]]

Not all of them do.

Thank you for the quick review :-)

https://hg.mozilla.org/webtools/tbpl/rev/d4ad9eb7fece

Comment 4

[Ed Morley [:emorley]]

In production :-)