Last Comment Bug 826678 - Disable warnings about the deprecated Return::Value module when loading Email::Send
: Disable warnings about the deprecated Return::Value module when loading Email...
Status: RESOLVED FIXED
:
Product: Bugzilla
Classification: Server Software
Component: Email Notifications (show other bugs)
: 4.4
: All All
: -- major (vote)
: Bugzilla 4.0
Assigned To: Frédéric Buclin
: default-qa
Mentors:
Depends on:
Blocks: 502625
  Show dependency treegraph
 
Reported: 2013-01-04 06:34 PST by Frédéric Buclin
Modified: 2013-01-05 15:28 PST (History)
1 user (show)
LpSolit: approval+
LpSolit: approval4.4+
LpSolit: blocking4.4+
LpSolit: approval4.2+
LpSolit: blocking4.2.5+
LpSolit: approval4.0+
LpSolit: blocking4.0.10+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch, v1 (976 bytes, patch)
2013-01-04 06:34 PST, Frédéric Buclin
no flags Details | Diff | Splinter Review
patch, v2 (1.49 KB, patch)
2013-01-04 08:17 PST, Frédéric Buclin
wicked: review+
Details | Diff | Splinter Review

Description Frédéric Buclin 2013-01-04 06:34:24 PST
Created attachment 697896 [details] [diff] [review]
patch, v1

As explained in bug 502625 comment 8, Return::Value 1.666002, which has been released last week, throws warnings every time this module is loaded about it being deprecated. All Bugzilla releases depend on Return::Value via Email::Send. Till bug 502625 is fixed (replace Email::Send by Email::Sender), we have to disable these warnings, else it's litterally polluting the web server error log (several tens of lines in the error log every time an email is sent!).

In the attached patch, I didn't patch Bugzilla::Send::Sendmail, despite it explicitly loads Return::Value, because this module is loaded by Bugzilla::Mailer which already contains $Return::Value::NO_CLUCK = 1.

I want to take this fix for 4.0.10 despite it's not a security bug, because the 4.0 branch will reach EOL at the end of 2013 at the earliest, and I suspect several admins will update their Perl modules meanwhile, including Return::Value. About the 3.6 branch, I doubt we will have another release on this branch as 4.4 final is almost there, and so this branch is very close to EOL.
Comment 1 Frédéric Buclin 2013-01-04 08:17:24 PST
Created attachment 697925 [details] [diff] [review]
patch, v2

When checksetup.pl checks if Email::Send is installed, the same warning is displayed. So we have to disable the warning there too.
Comment 2 Teemu Mannermaa (:wicked) 2013-01-05 12:57:34 PST
Comment on attachment 697925 [details] [diff] [review]
patch, v2

Ewww, what nasty spewage. This patch does the trick for trunk but it'll need backports.
Comment 3 Frédéric Buclin 2013-01-05 15:23:24 PST
(In reply to Teemu Mannermaa (:wicked) from comment #2)
> This patch does the trick for trunk but it'll need backports.

No backport needed. I just need to replace |use parent| by |use base| to fix the bitrot. I will do it on checkin.
Comment 4 Frédéric Buclin 2013-01-05 15:28:19 PST
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Mailer.pm
modified Bugzilla/Config/MTA.pm
modified Bugzilla/Install/Requirements.pm
Committed revision 8548.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified Bugzilla/Mailer.pm
modified Bugzilla/Config/MTA.pm
modified Bugzilla/Install/Requirements.pm
Committed revision 8498.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/
modified Bugzilla/Mailer.pm
modified Bugzilla/Config/MTA.pm
modified Bugzilla/Install/Requirements.pm
Committed revision 8183.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified Bugzilla/Mailer.pm
modified Bugzilla/Config/MTA.pm
modified Bugzilla/Install/Requirements.pm
Committed revision 7740.

Note You need to log in before you can comment on or make changes to this bug.