826678 - Disable warnings about the deprecated Return::Value module when loading Email::Send

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect)

Description

[Frédéric Buclin]

Attachment: patch, v1

As explained in bug 502625 comment 8, Return::Value 1.666002, which has been released last week, throws warnings every time this module is loaded about it being deprecated. All Bugzilla releases depend on Return::Value via Email::Send. Till bug 502625 is fixed (replace Email::Send by Email::Sender), we have to disable these warnings, else it's litterally polluting the web server error log (several tens of lines in the error log every time an email is sent!).

In the attached patch, I didn't patch Bugzilla::Send::Sendmail, despite it explicitly loads Return::Value, because this module is loaded by Bugzilla::Mailer which already contains $Return::Value::NO_CLUCK = 1.

I want to take this fix for 4.0.10 despite it's not a security bug, because the 4.0 branch will reach EOL at the end of 2013 at the earliest, and I suspect several admins will update their Perl modules meanwhile, including Return::Value. About the 3.6 branch, I doubt we will have another release on this branch as 4.4 final is almost there, and so this branch is very close to EOL.

Comment 1

[Frédéric Buclin]

Attachment: patch, v2

When checksetup.pl checks if Email::Send is installed, the same warning is displayed. So we have to disable the warning there too.

Comment 2

[Teemu Mannermaa (:wicked)]

Comment on attachment 697925 [details] [diff] [review]
patch, v2

Ewww, what nasty spewage. This patch does the trick for trunk but it'll need backports.

Comment 3

[Frédéric Buclin]

(In reply to Teemu Mannermaa (:wicked) from comment #2)
> This patch does the trick for trunk but it'll need backports.

No backport needed. I just need to replace |use parent| by |use base| to fix the bitrot. I will do it on checkin.

Comment 4

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Mailer.pm
modified Bugzilla/Config/MTA.pm
modified Bugzilla/Install/Requirements.pm
Committed revision 8548.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.4/
modified Bugzilla/Mailer.pm
modified Bugzilla/Config/MTA.pm
modified Bugzilla/Install/Requirements.pm
Committed revision 8498.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.2/
modified Bugzilla/Mailer.pm
modified Bugzilla/Config/MTA.pm
modified Bugzilla/Install/Requirements.pm
Committed revision 8183.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
modified Bugzilla/Mailer.pm
modified Bugzilla/Config/MTA.pm
modified Bugzilla/Install/Requirements.pm
Committed revision 7740.