Closed Bug 826695 Opened 11 years ago Closed 11 years ago

Fix developer toolbar button alignment

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(firefox20 verified)

VERIFIED FIXED
Firefox 21
Tracking Status
firefox20 --- verified

People

(Reporter: Optimizer, Assigned: Optimizer)

References

Details

Attachments

(1 file, 2 obsolete files)

After bug 818428, the wrench icon is misaligned on Windows and Linux.
Attached patch Quick Fix (obsolete) — Splinter Review
Makes the right margin of the icon 0px.
Right margin was 5px and 2px on Windows and Linux resp. due to the the rule 

.toolbarbutton-icon[label]:not([label=""]),
.toolbarbutton-icon[type="menu"] {
  -moz-margin-end: (5|2)px;
}

in

chrome://global/skin/toolbarbutton.css
Attachment #697910 - Flags: review?(dao)
Blocks: 818428
Whiteboard: [has-patch]
Comment on attachment 697910 [details] [diff] [review]
Quick Fix

This looks like it won't have the desired effect in RTL locales.
Attachment #697910 - Flags: review?(dao) → review-
Ah, you are right. I should also use -moz-margin-end. patch soon.
Attached patch patch v2.0 (obsolete) — Splinter Review
Using -moz-margin-end to support RTL.
Attachment #697910 - Attachment is obsolete: true
Attachment #699565 - Flags: review?(dao)
Comment on attachment 699565 [details] [diff] [review]
patch v2.0

Just write 0 instead of 0px.
Attachment #699565 - Flags: review?(dao) → review+
Attached patch patch v2.1Splinter Review
Carry forward r+

changed 0px to 0.
Attachment #699565 - Attachment is obsolete: true
Attachment #699812 - Flags: review+
Does this need Aurora uplift ?
Flags: needinfo?(paul)
Whiteboard: [has-patch] → [land-in-fx-team]
(In reply to Girish Sharma [:Optimizer] from comment #7)
> Does this need Aurora uplift ?

It won't hurt.
Flags: needinfo?(paul)
https://hg.mozilla.org/mozilla-central/rev/659e875b8e47
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 21
Comment on attachment 699812 [details] [diff] [review]
patch v2.1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 818428
User impact if declined: The icon will be misaligned on all the three platforms
Testing completed (on m-c, etc.): Tested on latest Nightly. Icon is centered
Risk to taking this patch (and alternatives if risky): None
String or UUID changes made by this patch: None
Attachment #699812 - Flags: approval-mozilla-aurora?
Attachment #699812 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [land-in-aurora]
I confirm the fix is verified on FF 20.b6 on Windows 7 x64:

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0(20130320062118)
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.