826695 - Fix developer toolbar button alignment

Status: VERIFIED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Description

[Girish Sharma [:Optimizer]]

After bug 818428, the wrench icon is misaligned on Windows and Linux.

Comment 1

[Girish Sharma [:Optimizer]]

Attachment: Quick Fix

Makes the right margin of the icon 0px.
Right margin was 5px and 2px on Windows and Linux resp. due to the the rule 

.toolbarbutton-icon[label]:not([label=""]),
.toolbarbutton-icon[type="menu"] {
  -moz-margin-end: (5|2)px;
}

in

chrome://global/skin/toolbarbutton.css

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 697910 [details] [diff] [review]
Quick Fix

This looks like it won't have the desired effect in RTL locales.

Comment 3

[Girish Sharma [:Optimizer]]

Ah, you are right. I should also use -moz-margin-end. patch soon.

Comment 4

[Girish Sharma [:Optimizer]]

Attachment: patch v2.0

Using -moz-margin-end to support RTL.

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 699565 [details] [diff] [review]
patch v2.0

Just write 0 instead of 0px.

Comment 6

[Girish Sharma [:Optimizer]]

Attachment: patch v2.1

Carry forward r+

changed 0px to 0.

Comment 7

[Girish Sharma [:Optimizer]]

Does this need Aurora uplift ?

Comment 8

[Paul Rouget [:paul]]

(In reply to Girish Sharma [:Optimizer] from comment #7)
> Does this need Aurora uplift ?

It won't hurt.

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/659e875b8e47

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/659e875b8e47

Comment 11

[Girish Sharma [:Optimizer]]

Comment on attachment 699812 [details] [diff] [review]
patch v2.1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 818428
User impact if declined: The icon will be misaligned on all the three platforms
Testing completed (on m-c, etc.): Tested on latest Nightly. Icon is centered
Risk to taking this patch (and alternatives if risky): None
String or UUID changes made by this patch: None

Comment 12

[Paul Rouget [:paul]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e3eb31db9caa

Comment 13

[Mihai Morar, (:MihaiMorar)]

I confirm the fix is verified on FF 20.b6 on Windows 7 x64:

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0(20130320062118)