826723 - Don't ask/give Google Suggestions in Private Browsing mode

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Gian-Carlo Pascutto [:gcp]]

Reported by a user:

When using Private Browsing on a fresh installation, it's possible to get asked if you want to enable Google Suggestions, while in a private tab (issue 1).

When answering yes, you do actually get Google suggestions (issue 2).

Both of those sound unexpected/unwanted to me. mfinkle checked Chrome and they actually disable Google in private mode. Based on this, putting severity as major.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Don't show suggestions or prompt in private tabs

The only time Tabs.getInstance().getSelectedTab() should be null is when we're restoring after a crash. We should never restore private tabs when that happens, so it should be safe to assume that null means non-private.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Brian Nicholson (:bnicholson) from comment #1)

> The only time Tabs.getInstance().getSelectedTab() should be null is when
> we're restoring after a crash. We should never restore private tabs when
> that happens, so it should be safe to assume that null means non-private.

It might be nice to add a comment to Tabs.getSelectedTab with this information. It could come in handy.

Comment 3

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/53dd117b51f2

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 700808 [details] [diff] [review]
Don't show suggestions or prompt in private tabs

[Approval Request Comment]
Bug caused by (feature/regressing bug #): none
User impact if declined: search suggestions will appear in private browsing mode
Testing completed (on m-c, etc.): just landed m-i
Risk to taking this patch (and alternatives if risky): low risk
String or UUID changes made by this patch: none

Comment 5

[bhavana bajaj [:bajaj]]

Comment on attachment 700808 [details] [diff] [review]
Don't show suggestions or prompt in private tabs

Low risk fix for a new feature on Fx20. Approving on aurora

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/53dd117b51f2

Comment 7

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0cce5a78c727

Comment 8

[Kevin Brosnan [Ex-Mozilla]]

This was fixed before it made to beta. I don't think this needs a relnote.

Comment 9

[Alex Keybl [:akeybl]]

(In reply to Kevin Brosnan [:kbrosnan] from comment #8)
> This was fixed before it made to beta. I don't think this needs a relnote.

Correct