If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

in-content PB view looks weird and has non-working context menu

RESOLVED FIXED in Firefox 20

Status

()

Firefox
Downloads Panel
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mak, Assigned: mconley)

Tracking

unspecified
Firefox 20
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

5 years ago
1. the border looks strange
2. the button looks weird
3. the context menu is totally disabled
(Assignee)

Comment 1

5 years ago
Some notes:

1) The context menu items only appear disabled on the first right-click. All subsequent right-clicks show a properly behaving context menu.
2) The strange button appearance appears on pinstripe and winstripe. gnomestripe is not affected.
(Assignee)

Comment 2

5 years ago
Created attachment 697948 [details] [diff] [review]
Fix for context menu

We were updating the commands on each progress event per download after the context menu was opened. However, the progress event will fire *after* the menu has opened, meaning the commands aren't up to date.

This patch causes us to refresh the commands only when the context menu is opened.
(Assignee)

Comment 3

5 years ago
Comment on attachment 697948 [details] [diff] [review]
Fix for context menu

This fixes the context menu problem for me. Have I missed anything?
Attachment #697948 - Flags: review?(mak77)
(Assignee)

Comment 4

5 years ago
Created attachment 697996 [details] [diff] [review]
WIP Patch 1

A better fix for the context menu (thanks Mano!), and styling fixes for winstripe. pinstripe is next.
Attachment #697948 - Attachment is obsolete: true
Attachment #697948 - Flags: review?(mak77)
(Assignee)

Comment 5

5 years ago
Created attachment 698004 [details] [diff] [review]
Patch v1

So it looks like command updating doesn't work for in-content chrome, so for now, we're doing it manually. I'll file a follow-up bug to fix command updating.

We also have to override some inContentUI theming that was causing the weird button appearance on winstripe and pinstripe.
Attachment #697996 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #698004 - Flags: review?(mak77)
(Assignee)

Comment 6

5 years ago
Filed a bug about command updaters in in-content chrome. See bug 826788.
(Reporter)

Comment 7

5 years ago
Comment on attachment 698004 [details] [diff] [review]
Patch v1

Review of attachment 698004 [details] [diff] [review]:
-----------------------------------------------------------------

Discussed over irc, if possible move in-content rules to contentAreaDownloadsView.css and optionally add a border around the richlistbox like the about:addons border.
Attachment #698004 - Flags: review?(mak77)
(Assignee)

Comment 8

5 years ago
Created attachment 698028 [details] [diff] [review]
Patch v2

Good idea, Marco. I've moved the overrides to the allDownloadsViewOverlay.css stylesheets.

Dropping request for border as discussed in IRC.

I'll test this on Windows before requesting review.
Attachment #698004 - Attachment is obsolete: true
(Assignee)

Comment 9

5 years ago
Comment on attachment 698028 [details] [diff] [review]
Patch v2

Ok, still functions properly on Windows.
Attachment #698028 - Flags: review?(mak77)
(Reporter)

Comment 10

5 years ago
Comment on attachment 698028 [details] [diff] [review]
Patch v2

Review of attachment 698028 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #698028 - Flags: review?(mak77) → review+
(Assignee)

Comment 11

5 years ago
Landed on mozilla-inbound as https://hg.mozilla.org/integration/mozilla-inbound/rev/3e4d1302c992
https://hg.mozilla.org/mozilla-central/rev/3e4d1302c992
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.