826729 - in-content PB view looks weird and has non-working context menu

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect, P1)

Description

[Marco Bonardo [:mak]]

1. the border looks strange
2. the button looks weird
3. the context menu is totally disabled

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Some notes:

1) The context menu items only appear disabled on the first right-click. All subsequent right-clicks show a properly behaving context menu.
2) The strange button appearance appears on pinstripe and winstripe. gnomestripe is not affected.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Fix for context menu

We were updating the commands on each progress event per download after the context menu was opened. However, the progress event will fire *after* the menu has opened, meaning the commands aren't up to date.

This patch causes us to refresh the commands only when the context menu is opened.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 697948 [details] [diff] [review]
Fix for context menu

This fixes the context menu problem for me. Have I missed anything?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: WIP Patch 1

A better fix for the context menu (thanks Mano!), and styling fixes for winstripe. pinstripe is next.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

So it looks like command updating doesn't work for in-content chrome, so for now, we're doing it manually. I'll file a follow-up bug to fix command updating.

We also have to override some inContentUI theming that was causing the weird button appearance on winstripe and pinstripe.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Filed a bug about command updaters in in-content chrome. See bug 826788.

Comment 7

[Marco Bonardo [:mak]]

Comment on attachment 698004 [details] [diff] [review]
Patch v1

Review of attachment 698004 [details] [diff] [review]:
-----------------------------------------------------------------

Discussed over irc, if possible move in-content rules to contentAreaDownloadsView.css and optionally add a border around the richlistbox like the about:addons border.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v2

Good idea, Marco. I've moved the overrides to the allDownloadsViewOverlay.css stylesheets.

Dropping request for border as discussed in IRC.

I'll test this on Windows before requesting review.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 698028 [details] [diff] [review]
Patch v2

Ok, still functions properly on Windows.

Comment 10

[Marco Bonardo [:mak]]

Comment on attachment 698028 [details] [diff] [review]
Patch v2

Review of attachment 698028 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Landed on mozilla-inbound as https://hg.mozilla.org/integration/mozilla-inbound/rev/3e4d1302c992

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3e4d1302c992