Closed Bug 826729 Opened 7 years ago Closed 7 years ago

in-content PB view looks weird and has non-working context menu

Categories

(Firefox :: Downloads Panel, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: mak, Assigned: mconley)

References

Details

Attachments

(1 file, 3 obsolete files)

1. the border looks strange
2. the button looks weird
3. the context menu is totally disabled
Some notes:

1) The context menu items only appear disabled on the first right-click. All subsequent right-clicks show a properly behaving context menu.
2) The strange button appearance appears on pinstripe and winstripe. gnomestripe is not affected.
Attached patch Fix for context menu (obsolete) — Splinter Review
We were updating the commands on each progress event per download after the context menu was opened. However, the progress event will fire *after* the menu has opened, meaning the commands aren't up to date.

This patch causes us to refresh the commands only when the context menu is opened.
Comment on attachment 697948 [details] [diff] [review]
Fix for context menu

This fixes the context menu problem for me. Have I missed anything?
Attachment #697948 - Flags: review?(mak77)
Attached patch WIP Patch 1 (obsolete) — Splinter Review
A better fix for the context menu (thanks Mano!), and styling fixes for winstripe. pinstripe is next.
Attachment #697948 - Attachment is obsolete: true
Attachment #697948 - Flags: review?(mak77)
Attached patch Patch v1 (obsolete) — Splinter Review
So it looks like command updating doesn't work for in-content chrome, so for now, we're doing it manually. I'll file a follow-up bug to fix command updating.

We also have to override some inContentUI theming that was causing the weird button appearance on winstripe and pinstripe.
Attachment #697996 - Attachment is obsolete: true
Filed a bug about command updaters in in-content chrome. See bug 826788.
Comment on attachment 698004 [details] [diff] [review]
Patch v1

Review of attachment 698004 [details] [diff] [review]:
-----------------------------------------------------------------

Discussed over irc, if possible move in-content rules to contentAreaDownloadsView.css and optionally add a border around the richlistbox like the about:addons border.
Attachment #698004 - Flags: review?(mak77)
Attached patch Patch v2Splinter Review
Good idea, Marco. I've moved the overrides to the allDownloadsViewOverlay.css stylesheets.

Dropping request for border as discussed in IRC.

I'll test this on Windows before requesting review.
Attachment #698004 - Attachment is obsolete: true
Comment on attachment 698028 [details] [diff] [review]
Patch v2

Ok, still functions properly on Windows.
Attachment #698028 - Flags: review?(mak77)
Comment on attachment 698028 [details] [diff] [review]
Patch v2

Review of attachment 698028 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #698028 - Flags: review?(mak77) → review+
https://hg.mozilla.org/mozilla-central/rev/3e4d1302c992
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.