826818 - Assert that extra threads not used when memory reports run on a different thread

Status: RESOLVED INCOMPLETE

(Core :: JavaScript Engine, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

See bug 813867 comment 41, it might be a good idea to add some kind of assertions that additional threads (gc, etc.) are not used when memory reporting happens on a different thread.

Comment 1

[Jason Orendorff [:jorendorff]]

Can you just do this in your patch in that bug? Should be trivial, just assert that rt->useHelperThreads() is false in the JS function you're calling. r=me. :)

I think what you're doing is *probably* safe even without such an assertion, but it would warrant a review by someone who understands the GC (and the GC helper thread).

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Doh, I already landed it :(

But even so I'm not sure that a simple assert is the right thing to do here. rt->useHelperThreads() will be true for the main thread, right? And we're calling the same memory reporting function that the main thread is, I'm pretty sure.

This is really more of a workers problem tbh.